Skip to content

fix(tui): preserve log rows during horizontal panning - #20

Merged
mingchuno merged 2 commits into
mainfrom
agent/18-1
Sep 23, 2026
Merged

mingchuno merged 2 commits into
mainfrom
agent/18-1

Conversation

@mingchuno

Copy link
Copy Markdown
Owner

Summary

  • preserve a viewport row when horizontal clipping leaves a log record empty
  • keep visible records and the reported line range stationary while panning
  • cover readable and raw output, live following after an append, and a manually scrolled completed run

Validation

  • pnpm verify passed (pnpm check, pnpm lint, and pnpm test)
  • 193 tests passed, 2 skipped, and 0 failed

Limitations

  • the live Codex and Copilot inspection tests were skipped
  • validation used automated rendered-frame assertions; the supplied terminal recording was not replayed manually

Closes #18

Refs #18

Render clipped log records as blank rows so horizontal panning cannot
collapse the viewport or shift neighboring records vertically.

Closes #18

Co-authored-by: Codex <noreply@openai.com>
Agent-Workflows-Run: 16a3b0c4-3c17-4274-b0ef-836e8a99bced

@mingchuno mingchuno left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 3eddc1b

The implementation appears correct and scoped to the shared Logs viewer. One validation gap remains: the raw/readable coverage does not exercise records that render differently between those modes.

Comment thread tests/tui.test.tsx
@mingchuno
mingchuno marked this pull request as ready for review September 23, 2026 19:59
@mingchuno
mingchuno merged commit 9cf9de2 into main Sep 23, 2026
4 checks passed
@mingchuno
mingchuno deleted the agent/18-1 branch September 23, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: keep log rows stationary during horizontal panning

1 participant