Reorganizing tests#970
Merged
michelebastione merged 8 commits intoJun 1, 2026
Merged
Conversation
Moved issue tests in their own folder, separated gitee issues from github issues and ordered them, and moved models to own file.
Moved models to own folder and cleaned up some code paths
Moved `MiniExcelOpenXmlConfigurationTests` and `MiniExcelAutoAdjustWidthTests` to own folder and separated models to own file
Moved `MiniExcelOpenXmlTests` and `MiniExcelOpenXmlAsyncTests` classes to their own folder and separated models into their own file
Separated tests into Main and Issues folders, and moved models to their own file
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes the test suite by moving test files into structured subdirectories (such as Issues, Main, Configuration, and MultipleSheets), extracting test DTOs and models into dedicated Models.cs files, and refactoring asynchronous tests to use proper async/await patterns instead of blocking calls. Additionally, the AppVeyor configuration and its references have been removed. The review feedback focuses on improving resource management within the tests, specifically recommending the use of AutoDeletingPath to guarantee the cleanup of temporary files upon test failures, and wrapping returned DataTable instances in using statements to ensure proper disposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated tests into folders pertaining to their functionalities, and moved all models to their own files.
Also removed the appveyor.yml file since it's not functional and not relevant to the project anymore.