refactor: migrate to Yarn Berry (v3.2.1) by ThatOneCalculator · Pull Request #8764 · misskey-dev/misskey

ThatOneCalculator · 2022-05-29T19:43:32Z

What

Migrate to Yarn Berry (v3.2.1)

Resolve #5858
Supersede #8472

Why

As yarn v3 (yarn berry) has worked with Misskey for a while and provides better performance when compiling while still retaining backwards compatibility with yarn v1, I feel that upgrading to yarn berry would be a smart choice.

Additional info

I've been building Misskey with yarn v3 for two months now both on my server for production and on my development machine with absolutely no problems. This PR was made simply by running yarn with yarn 3.2.1 and following the yarn migration instructions.

Further steps

Documentation on Misskey Hub would have to be updated
Update workflow (especially mocha and e2e)
Update the install script (maybe docker too?)

ThatOneCalculator · 2022-05-29T22:55:51Z

@acid-chicken I'd personally like your feedback on this PR first if you don't mind, as you've been the most involved with Yarn Berry discussion.

acid-chicken

Thank you for your work.
I believe that by using the node_modules linker, we can upgrade without facing most of the problems, so I think this PR is fine with the current policy for now, regardless of whether we move to PnP mode in the future or not.

Also, since Yarn berry has built-in monorepo management system called workspaces, so it would be great (and probably easy) to also improve the current situation, which is awkwardly realized by scripts/install-packages.js and so on.

acid-chicken · 2022-05-29T23:29:16Z

Also, since there are opinions like #5858 (comment), it would be better if Corepack could be used as a boot loader for Yarn berry (instead of placing .yarn/releases/yarn-3.2.1.cjs directly).

ThatOneCalculator · 2022-05-29T23:47:03Z

Running corepack enable in the repo folder didn't change anything, is there a proper way to enable corepack?

acid-chicken · 2022-05-30T00:02:01Z

corepack enable is related to environment settings, so it will not change anything in the repository (excluding docs).
Can you confirm that deleting .yarn/releases/yarn-3.2.1.cjs with "packageManager" specified in package.json after running it still works?

ThatOneCalculator · 2022-05-30T00:09:15Z

Can you confirm that deleting .yarn/releases/yarn-3.2.1.cjs with "packageManager" specified in package.json after running it still works?

@acid-chicken yep!

ThatOneCalculator · 2022-05-30T00:11:08Z

Seems like the labeler bot adds back removed labels every commit ^^"

ThatOneCalculator · 2022-05-30T00:15:42Z

Also, since Yarn berry has built-in monorepo management system called workspaces, so it would be great (and probably easy) to also improve the current situation, which is awkwardly realized by scripts/install-packages.js and so on.

Done!

acid-chicken · 2022-05-30T00:54:24Z

I assume packages/*/yarn.lock will no longer be used after yarn install should consolidate the lock files in /yarn.lock.

tamaina · 2022-10-29T10:11:07Z

developに追従した

tamaina · 2022-11-07T15:38:05Z

マージしちゃう？

tamaina · 2022-11-13T13:01:09Z

yarn install --immutableであれば1GiBで足りるかも

rinsuki · 2022-11-13T17:12:13Z

そもそもproductionのビルドって yarn v1 版でも1GBで足りるんだっけ？vite入ったから行ける？

tamaina · 2022-11-13T17:13:51Z

無理だった
でも1536MiBならいけた

packages/backend/package.json

packages/client/package.json

syuilo · 2022-11-21T10:49:32Z

packages/backend/package.json

 		"ioredis": "4.28.5",
 		"ip-cidr": "3.0.10",
 		"is-svg": "4.3.2",
+		"jest-mock": "^29.0.3",


要る？
要るとしてもdevDependenciesじゃないかしら

syuilo · 2022-11-21T10:49:47Z

packages/backend/package.json

 		"node-fetch": "3.3.0",
 		"nodemailer": "6.8.0",
 		"nsfwjs": "2.4.2",
+		"oauth": "^0.10.0",


DiscordServerServiceとGithubServerServiceでは使われているけど

tamaina · 2022-11-22T05:34:36Z

Fastifyと統合するのちょっと骨折れそう

syuilo

YOSASOU

syuilo · 2022-11-24T06:39:18Z

🙏🏻🙏🏻🙏🏻

ThatOneCalculator · 2022-11-24T06:44:24Z

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

syuilo · 2022-12-22T09:17:44Z

nodeLinker: pnpmだと型の不具合が起きるっぽい
https://mstdn.rinsuki.net/@rinsuki/109556531278084299

rinsuki · 2022-12-22T15:02:11Z

いやこれ peerDependencies に追加すれば解決する

Yarn berry

5c7fca4

github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels May 29, 2022

ThatOneCalculator added 3 commits May 29, 2022 12:46

Add .yarn to dockerignore

76e399c

Mention in CHANGELOG

ea7d535

Update Dockerfile

9652183

ThatOneCalculator marked this pull request as draft May 29, 2022 20:00

Proper upgrade to yarn

3140a3f

ThatOneCalculator marked this pull request as ready for review May 29, 2022 20:13

ThatOneCalculator changed the title ~~Add compatibility for Yarn Berry (v3)~~ Switch to Yarn Berry (v3.2.1) May 29, 2022

acid-chicken self-requested a review May 29, 2022 23:07

acid-chicken reviewed May 29, 2022

View reviewed changes

acid-chicken added 🛠️Dev Development of Misskey itself and removed packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels May 29, 2022

use "packageManager"

9d1c8b4

github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels May 30, 2022

ThatOneCalculator added 2 commits May 29, 2022 17:14

Replace install-packages.js with workspaces

fd8170f

Replace install-packages.js with workspaces

6ba6dd1

Typo

9afb410

ThatOneCalculator requested a review from acid-chicken May 30, 2022 00:16

tamaina added 3 commits October 13, 2022 03:52

update-lockfile

7e5d7b5

Merge branch 'develop' into pr/ThatOneCalculator/8764

24a2bb5

update lockfile

fad2d65

Merge branch 'develop' into pr/ThatOneCalculator/8764

d4b8c0e

Merge branch 'develop' into pr/ThatOneCalculator/8764

7c406ea

This comment was marked as abuse.

Sign in to view

update lockfile

1615135

This comment was marked as abuse.

Sign in to view

Merge branch 'develop' into pr/ThatOneCalculator/8764

af8fd01

syuilo reviewed Nov 21, 2022

View reviewed changes

packages/backend/package.json Show resolved Hide resolved

syuilo reviewed Nov 21, 2022

View reviewed changes

packages/client/package.json Show resolved Hide resolved

syuilo reviewed Nov 21, 2022

View reviewed changes

tamaina added 2 commits November 22, 2022 14:26

Merge branch 'develop' into pr/ThatOneCalculator/8764

61568ad

move jest-mock, update lockfile

461b36c

tamaina requested a review from syuilo November 22, 2022 05:34

syuilo approved these changes Nov 24, 2022

View reviewed changes

syuilo merged commit bdbc448 into misskey-dev:develop Nov 24, 2022

acid-chicken mentioned this pull request Dec 6, 2022

docker run have been failed since yarn v3 introduced #9291

Closed

gaikwadrahul8 mentioned this pull request Apr 4, 2023

Cannot find module 'long' error when trying to run @tensorflow/tfjs module in Node.js tensorflow/tfjs#6841

Closed

Uh oh!

Conversation

ThatOneCalculator commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Additional info

Further steps

Uh oh!

ThatOneCalculator commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acid-chicken left a comment

Choose a reason for hiding this comment

Uh oh!

acid-chicken commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThatOneCalculator commented May 29, 2022

Uh oh!

acid-chicken commented May 30, 2022

Uh oh!

ThatOneCalculator commented May 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThatOneCalculator commented May 30, 2022

Uh oh!

ThatOneCalculator commented May 30, 2022

Uh oh!

acid-chicken commented May 30, 2022

Uh oh!

tamaina commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tamaina commented Nov 7, 2022

Uh oh!

This comment was marked as abuse.

This comment was marked as abuse.

tamaina commented Nov 13, 2022

Uh oh!

rinsuki commented Nov 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tamaina commented Nov 13, 2022

Uh oh!

Uh oh!

Uh oh!

syuilo Nov 21, 2022

Choose a reason for hiding this comment

Uh oh!

syuilo Nov 21, 2022

Choose a reason for hiding this comment

Uh oh!

tamaina Nov 22, 2022

Choose a reason for hiding this comment

Uh oh!

tamaina commented Nov 22, 2022

Uh oh!

syuilo left a comment

Choose a reason for hiding this comment

Uh oh!

syuilo commented Nov 24, 2022

Uh oh!

ThatOneCalculator commented Nov 24, 2022

Uh oh!

syuilo commented Dec 22, 2022

Uh oh!

rinsuki commented Dec 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ThatOneCalculator commented May 29, 2022 •

edited

Loading

ThatOneCalculator commented May 29, 2022 •

edited

Loading

acid-chicken commented May 29, 2022 •

edited

Loading

ThatOneCalculator commented May 30, 2022 •

edited

Loading

tamaina commented Oct 29, 2022 •

edited

Loading

rinsuki commented Nov 13, 2022 •

edited

Loading