Open
Conversation
Li-Yuanyuan
commented
Jan 7, 2025
Li-Yuanyuan
commented
- Fixed copy-paste issues for ECDSA SHA-384.
- Resolved the issue where ECDSA SHA-256 was always chosen.
- Fixed the SFV parsing issue.
Fixed the issue where ecdsa-sha256 is always chosen.
Fixed a copy-paste issue with `ecdsa-p384-sha384`
Update verify.ts
Fixed SFV parsing failure, added the sfv dictionary option to `RFC9421SignatureBaseFactory`.
Fix ecdsa sha256 issue
Update parse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.