Refactor list LiveViews around Flop

.gitignore

@@ -44,3 +44,5 @@ config/dev.overrides.exs
 # Log files
 /logs/
 .expert/
+
+.envrc

.serena/.gitignore

@@ -0,0 +1,2 @@
+/cache
+/project.local.yml

.serena/project.yml

@@ -0,0 +1,133 @@
+# the name by which the project can be referenced within Serena
+project_name: "reencodarr"
+
+
+# list of languages for which language servers are started; choose from:
+#   al                  angular             ansible             bash                clojure
+#   cpp                 cpp_ccls            crystal             csharp              csharp_omnisharp
+#   dart                elixir              elm                 erlang              fortran
+#   fsharp              go                  groovy              haskell             haxe
+#   hlsl                html                java                json                julia
+#   kotlin              lean4               lua                 luau                markdown
+#   matlab              msl                 nix                 ocaml               pascal
+#   perl                php                 php_phpactor        powershell          python
+#   python_jedi         python_ty           r                   rego                ruby
+#   ruby_solargraph     rust                scala               scss                solidity
+#   svelte              swift               systemverilog       terraform           toml
+#   typescript          typescript_vts      vue                 yaml                zig
+#   (This list may be outdated. For the current list, see values of Language enum here:
+#   https://github.com/oraios/serena/blob/main/src/solidlsp/ls_config.py
+#   For some languages, there are alternative language servers, e.g. csharp_omnisharp, ruby_solargraph.)
+# Note:
+#   - For C, use cpp
+#   - For JavaScript, use typescript
+#   - For Angular projects, use angular (subsumes typescript+html; requires `npm install` in the project root)
+#   - For Svelte projects, use svelte (subsumes typescript/javascript for .svelte projects; requires npm)
+#   - For SCSS / Sass / plain CSS, use scss (some-sass-language-server handles all three)
+#   - For Free Pascal/Lazarus, use pascal
+# Special requirements:
+#   Some languages require additional setup/installations.
+#   See here for details: https://oraios.github.io/serena/01-about/020_programming-languages.html#language-servers
+# When using multiple languages, the first language server that supports a given file will be used for that file.
+# The first language is the default language and the respective language server will be used as a fallback.
+# Note that when using the JetBrains backend, language servers are not used and this list is correspondingly ignored.
+languages:
+- elixir
+
+# the encoding used by text files in the project
+# For a list of possible encodings, see https://docs.python.org/3.11/library/codecs.html#standard-encodings
+encoding: "utf-8"
+
+# line ending convention to use when writing source files.
+# Possible values: unset (use global setting), "lf", "crlf", or "native" (platform default)
+# This does not affect Serena's own files (e.g. memories and configuration files), which always use native line endings.
+line_ending:
+
+# The language backend to use for this project.
+# If not set, the global setting from serena_config.yml is used.
+# Valid values: LSP, JetBrains
+# Note: the backend is fixed at startup. If a project with a different backend
+# is activated post-init, an error will be returned.
+language_backend:
+
+# whether to use project's .gitignore files to ignore files
+ignore_all_files_in_gitignore: true
+
+# advanced configuration option allowing to configure language server-specific options.
+# Maps the language key to the options.
+# Have a look at the docstring of the constructors of the LS implementations within solidlsp (e.g., for C# or PHP) to see which options are available.
+# No documentation on options means no options are available.
+ls_specific_settings: {}
+
+# list of additional workspace folder paths for cross-package reference support (e.g. in monorepos).
+# Paths can be absolute or relative to the project root.
+# Each folder is registered as an LSP workspace folder, enabling language servers to discover
+# symbols and references across package boundaries.
+# Currently supported for: TypeScript.
+# Example:
+#   additional_workspace_folders:
+#     - ../sibling-package
+#     - ../shared-lib
+additional_workspace_folders: []
+
+# list of additional paths to ignore in this project.
+# Same syntax as gitignore, so you can use * and **.
+# Note: global ignored_paths from serena_config.yml are also applied additively.
+ignored_paths: []
+
+# whether the project is in read-only mode
+# If set to true, all editing tools will be disabled and attempts to use them will result in an error
+# Added on 2025-04-18
+read_only: false
+
+# list of tool names to exclude.
+# This extends the existing exclusions (e.g. from the global configuration)
+# Find the list of tools here: https://oraios.github.io/serena/01-about/035_tools.html
+excluded_tools: []
+
+# list of tools to include that would otherwise be disabled (particularly optional tools that are disabled by default).
+# This extends the existing inclusions (e.g. from the global configuration).
+# Find the list of tools here: https://oraios.github.io/serena/01-about/035_tools.html
+included_optional_tools: []
+
+# fixed set of tools to use as the base tool set (if non-empty), replacing Serena's default set of tools.
+# This cannot be combined with non-empty excluded_tools or included_optional_tools.
+# Find the list of tools here: https://oraios.github.io/serena/01-about/035_tools.html
+fixed_tools: []
+
+# list of mode names that are to be activated by default, overriding the setting in the global configuration.
+# The full set of modes to be activated is base_modes (from global config) + default_modes + added_modes.
+# If the setting is undefined/empty, the default_modes from the global configuration (serena_config.yml) apply.
+# Otherwise, this overrides the setting from the global configuration (serena_config.yml).
+# Therefore, you can set this to [] if you do not want the default modes defined in the global config to apply
+# for this project.
+# This setting can, in turn, be overridden by CLI parameters (--mode).
+# See https://oraios.github.io/serena/02-usage/050_configuration.html#modes
+default_modes:
+
+# list of mode names to be activated additionally for this project, e.g. ["query-projects"]
+# The full set of modes to be activated is base_modes (from global config) + default_modes + added_modes.
+# See https://oraios.github.io/serena/02-usage/050_configuration.html#modes
+added_modes:
+
+# initial prompt for the project. It will always be given to the LLM upon activating the project
+# (contrary to the memories, which are loaded on demand).
+initial_prompt: ""
+
+# time budget (seconds) per tool call for the retrieval of additional symbol information
+# such as docstrings or parameter information.
+# This overrides the corresponding setting in the global configuration; see the documentation there.
+# If null or missing, use the setting from the global configuration.
+symbol_info_budget:
+
+# list of regex patterns which, when matched, mark a memory entry as read‑only.
+# Extends the list from the global configuration, merging the two lists.
+read_only_memory_patterns: []
+
+# list of regex patterns for memories to completely ignore.
+# Matching memories will not appear in list_memories or activate_project output
+# and cannot be accessed via read_memory or write_memory.
+# To access ignored memory files, use the read_file tool on the raw file path.
+# Extends the list from the global configuration, merging the two lists.
+# Example: ["_archive/.*", "_episodes/.*"]
+ignored_memory_patterns: []

AGENTS.md

@@ -62,6 +62,10 @@
 - Use `meck` where the current test suite already uses it for external command mocking.
 - When changing sync, parser, state-machine, or LiveView behavior, add or update tests near the affected module.
 
+## List LiveViews (Flop)
+- Paginated list pages (`VideosLive`, `FailuresLive`, `BadFilesLive`) use `handle_params`, URL query params, and `ReencodarrWeb.Live.FlopList` (`flop_pagination`, `patch_with_page`, `parse_page`).
+- List APIs return `{items, %Flop.Meta{}}`: `Media.list_videos_paginated/1`, `Media.list_failures/1`, `Media.list_bad_file_issues/2`.
+
 ## File/Module Pointers
 - `lib/reencodarr/sync.ex` - Sonarr/Radarr sync and batch upserts.
 - `lib/reencodarr/media/video_upsert.ex` - guarded upsert logic, bitrate/VMAF handling.

lib/reencodarr/bad_files/state.ex

@@ -5,81 +5,135 @@ defmodule Reencodarr.BadFiles.State do
 
   @active_statuses [:open, :queued, :processing, :waiting_for_replacement, :failed]
   @resolved_statuses [:replaced_clean, :dismissed]
-  @resolved_limit 50
-
-  @spec load(map()) :: map()
-  def load(assigns) do
-    filters = [
-      service: assigns.service_filter,
-      kind: assigns.kind_filter,
-      search: assigns.search_query
-    ]
-
-    {active_statuses, resolved_statuses} = statuses_for_filter(assigns.status_filter)
-    active_issues = fetch_active_issues(filters, active_statuses, assigns)
-    active_total = fetch_active_total(filters, active_statuses)
-    issue_summary = Media.bad_file_issue_summary()
-    resolved_issues = fetch_resolved_issues(filters, resolved_statuses, assigns.show_resolved)
-    issues = active_issues ++ resolved_issues
+  @active_status_filters Map.new(@active_statuses, &{Atom.to_string(&1), &1})
+  @replacement_statuses [:processing, :waiting_for_replacement]
+
+  @spec load(map(), keyword()) :: map()
+  def load(assigns, opts \\ []) do
+    include_summary? = Keyword.get(opts, :include_summary, true)
+    statuses = statuses_for_filter(assigns.status_filter)
+    {issues, meta} = fetch_issues(statuses, assigns)
+    issue_summary = issue_summary(assigns, opts, include_summary?)
 
     %{
       issues: issues,
+      meta: meta,
       tracked_count:
         issue_summary.open + issue_summary.queued + issue_summary.processing +
           issue_summary.waiting_for_replacement + issue_summary.failed + issue_summary.resolved,
-      active_total: active_total,
-      active_issues: active_issues,
-      replacement_issues:
-        Enum.filter(active_issues, &(&1.status in [:processing, :waiting_for_replacement])),
-      resolved_issues: resolved_issues,
+      active_total: meta.total_count,
+      active_issues: issues,
+      replacement_issues: list_replacement_issues(assigns),
+      resolved_issues: side_resolved_issues(assigns),
       issue_summary: issue_summary
     }
   end
 
-  defp fetch_active_issues(_filters, [], _assigns), do: []
+  def active_statuses_for_filter("all"), do: @active_statuses
+  def active_statuses_for_filter("resolved"), do: []
+
+  def active_statuses_for_filter(status_filter) when is_binary(status_filter) do
+    case Map.fetch(@active_status_filters, status_filter) do
+      {:ok, status} -> [status]
+      :error -> @active_statuses
+    end
+  end
 
-  defp fetch_active_issues(filters, active_statuses, assigns) do
-    Media.list_bad_file_issues(
-      filters ++
-        [
-          statuses: active_statuses,
-          limit: assigns.per_page,
-          offset: (assigns.page - 1) * assigns.per_page
-        ]
+  def active_statuses_for_filter(_status_filter), do: @active_statuses
+
+  def list_active_issues(assigns, opts \\ []) do
+    page_size = Keyword.get(opts, :per_page, 250)
+
+    fetch_all_issues(
+      assigns,
+      active_statuses_for_filter(assigns.status_filter),
+      page_size
     )
   end
 
-  defp fetch_active_total(_filters, []), do: 0
+  def flop_params(assigns) do
+    %{
+      "page" => to_string(assigns.page),
+      "page_size" => to_string(assigns.per_page),
+      "service" => assigns.service_filter,
+      "kind" => assigns.kind_filter,
+      "search" => assigns.search_query
+    }
+  end
+
+  defp fetch_all_issues(_assigns, [], _page_size), do: []
 
-  defp fetch_active_total(filters, active_statuses) do
-    Media.count_bad_file_issues(Keyword.put_new(filters, :statuses, active_statuses))
+  defp fetch_all_issues(assigns, statuses, page_size) do
+    assigns
+    |> Map.put(:page, 1)
+    |> Map.put(:per_page, page_size)
+    |> fetch_all_active_issues(statuses, page_size, [])
+    |> Enum.reverse()
   end
 
-  defp fetch_resolved_issues(_filters, _resolved_statuses, false), do: []
-  defp fetch_resolved_issues(_filters, [], true), do: []
+  defp fetch_all_active_issues(assigns, statuses, page_size, acc) do
+    {issues, meta} = fetch_issues(statuses, assigns)
+    acc = Enum.reverse(issues, acc)
 
-  defp fetch_resolved_issues(filters, resolved_statuses, true) do
-    Media.list_bad_file_issues(filters ++ [statuses: resolved_statuses, limit: @resolved_limit])
+    if more_pages?(meta) do
+      assigns
+      |> Map.put(:page, meta.current_page + 1)
+      |> Map.put(:per_page, page_size)
+      |> fetch_all_active_issues(statuses, page_size, acc)
+    else
+      acc
+    end
   end
 
-  defp statuses_for_filter(status_filter) do
-    case status_filter do
-      "all" ->
-        {@active_statuses, @resolved_statuses}
+  defp list_replacement_issues(assigns) do
+    assigns
+    |> flop_params()
+    |> Media.list_bad_file_issue_previews(
+      statuses: @replacement_statuses,
+      limit: assigns.per_page
+    )
+  end
 
-      "resolved" ->
-        {[], @resolved_statuses}
+  defp issue_summary(_assigns, _opts, true), do: Media.bad_file_issue_summary()
 
-      other ->
-        status = String.to_existing_atom(other)
+  defp issue_summary(assigns, opts, false) do
+    Keyword.get(opts, :issue_summary) || assigns[:issue_summary] || Media.bad_file_issue_summary()
+  end
 
-        if status in @resolved_statuses do
-          {[], [status]}
-        else
-          {[status], []}
-        end
+  defp fetch_issues([], %{per_page: per_page}), do: {[], empty_meta(per_page)}
+
+  defp fetch_issues(statuses, assigns) do
+    Media.list_bad_file_issues(flop_params(assigns), statuses: statuses)
+  end
+
+  defp side_resolved_issues(%{status_filter: "resolved"}), do: []
+  defp side_resolved_issues(%{show_resolved: false}), do: []
+
+  defp side_resolved_issues(assigns) do
+    {issues, _meta} = fetch_issues(@resolved_statuses, Map.put(assigns, :page, 1))
+
+    issues
+  end
+
+  defp statuses_for_filter("all"), do: @active_statuses
+  defp statuses_for_filter("resolved"), do: @resolved_statuses
+
+  defp statuses_for_filter(status_filter) when is_binary(status_filter) do
+    case Map.fetch(@active_status_filters, status_filter) do
+      {:ok, status} -> [status]
+      :error -> @active_statuses
     end
-  rescue
-    ArgumentError -> {@active_statuses, @resolved_statuses}
+  end
+
+  defp statuses_for_filter(_status_filter), do: @active_statuses
+
+  defp more_pages?(%Flop.Meta{current_page: current_page, total_pages: total_pages})
+       when is_integer(current_page) and is_integer(total_pages),
+       do: current_page < total_pages
+
+  defp more_pages?(_meta), do: false
+
+  defp empty_meta(per_page) do
+    %Flop.Meta{current_page: 1, page_size: per_page, total_count: 0, total_pages: 1}
   end
 end