Update HolisticTraceAnalysis dependency to the traceinsight package#217
Open
tejadhith wants to merge 1 commit into
Open
Update HolisticTraceAnalysis dependency to the traceinsight package#217tejadhith wants to merge 1 commit into
tejadhith wants to merge 1 commit into
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chakra pins HolisticTraceAnalysis (HTA) to git commit
d731cc2einpyproject.toml, in both CI workflows (python_tests,end_to_end_tests), and inUSER_GUIDE.md. That mid-2024 checkpoint predates HTA's pandas-2.x compatibility fix (HTA PR #333), so runningchakra_trace_linkon a real trace logsCritical path analysis encountered an invalid graph structure: Cannot specify both 'axis' and 'index'/'columns'and silently skips critical-path analysis.HTA now publishes its releases to PyPI under the renamed distribution
traceinsight(0.6.0 / 0.6.1); the importable module remainshta, so no source changes are needed. This PR replaces the pinned git checkout with thetraceinsightpackage acrosspyproject.toml, both CI workflows, andUSER_GUIDE.md— which also removes the manual clone/submodule/editable-install step from CI.Test Plan
Environment: Python 3.13, torch 2.9.0+cu128, 2× V100;
traceinsight 0.6.1, PARAMet_replay,networkx 3.6.1.python -m pytest tests→ 117 passed (no regression).chakra_trace_link→Cannot specify both 'axis' and 'index'/'columns', critical path skipped.calculating critical path took 0.0027s,Linking process successful;chakra_converter→ valid.et(115COMP_NODE)..et= 154COMP_NODE+ 1METADATA_NODE+ 2COMM_COLL_NODE(ncclDevKernel_AllReduce_…); critical path runs. No regression on comm-heavy traces.import htastill resolves (module name unchanged in traceinsight 0.6.x).Additional Notes
HolisticTraceAnalysis→traceinsightat 0.6.x; the importable module stayshta.traceinsightonly exists at 0.6.0+, so a bare requirement cannot resolve below the fix.networkxchange: theDiGraph.__new__crash was specific to networkx 3.6.0 (networkx #8367) and is fixed in 3.6.1; nothing forces 3.6.0.mlc-chakraPyPI release is needed to propagate this topip install mlc-chakrausers.