Skip to content

Update HolisticTraceAnalysis dependency to the traceinsight package#217

Open
tejadhith wants to merge 1 commit into
mlcommons:mainfrom
tejadhith:update-hta-dependency
Open

Update HolisticTraceAnalysis dependency to the traceinsight package#217
tejadhith wants to merge 1 commit into
mlcommons:mainfrom
tejadhith:update-hta-dependency

Conversation

@tejadhith

Copy link
Copy Markdown

Summary

Chakra pins HolisticTraceAnalysis (HTA) to git commit d731cc2e in pyproject.toml, in both CI workflows (python_tests, end_to_end_tests), and in USER_GUIDE.md. That mid-2024 checkpoint predates HTA's pandas-2.x compatibility fix (HTA PR #333), so running chakra_trace_link on a real trace logs Critical path analysis encountered an invalid graph structure: Cannot specify both 'axis' and 'index'/'columns' and silently skips critical-path analysis.

HTA now publishes its releases to PyPI under the renamed distribution traceinsight (0.6.0 / 0.6.1); the importable module remains hta, so no source changes are needed. This PR replaces the pinned git checkout with the traceinsight package across pyproject.toml, both CI workflows, and USER_GUIDE.md — which also removes the manual clone/submodule/editable-install step from CI.

Test Plan

Environment: Python 3.13, torch 2.9.0+cu128, 2× V100; traceinsight 0.6.1, PARAM et_replay, networkx 3.6.1.

  • Unit suite: python -m pytest tests117 passed (no regression).
  • End-to-end, single-rank MLP: chakra_trace_link
    • before (HTA 0.5.0): Cannot specify both 'axis' and 'index'/'columns', critical path skipped.
    • after (traceinsight 0.6.1): calculating critical path took 0.0027s, Linking process successful; chakra_converter → valid .et (115 COMP_NODE).
  • End-to-end, 2-rank DDP/NCCL: link + convert succeed; .et = 154 COMP_NODE + 1 METADATA_NODE + 2 COMM_COLL_NODE (ncclDevKernel_AllReduce_…); critical path runs. No regression on comm-heavy traces.
  • import hta still resolves (module name unchanged in traceinsight 0.6.x).

Additional Notes

  • HTA's PyPI distribution was renamed HolisticTraceAnalysistraceinsight at 0.6.x; the importable module stays hta. traceinsight only exists at 0.6.0+, so a bare requirement cannot resolve below the fix.
  • No networkx change: the DiGraph.__new__ crash was specific to networkx 3.6.0 (networkx #8367) and is fixed in 3.6.1; nothing forces 3.6.0.
  • A new mlc-chakra PyPI release is needed to propagate this to pip install mlc-chakra users.
  • Refs: HTA PR #333 (pandas 2.x fix), networkx #8367.

@tejadhith tejadhith requested a review from a team as a code owner July 7, 2026 17:37
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant