Skip to content

ARC-134 refactor SCSS#20

Merged
rshiggin merged 4 commits into
ARC-135-repositories-viewfrom
ARC-134-refactor-scss
Jun 18, 2026
Merged

ARC-134 refactor SCSS#20
rshiggin merged 4 commits into
ARC-135-repositories-viewfrom
ARC-134-refactor-scss

Conversation

@rshiggin

Copy link
Copy Markdown
Member

Moved active SCSS to top-level app/assets/stylesheets. To aid development, split SCSS into separate compiled CSS files:

  1. default Bootstrap 5 bootstrap.css
  2. custom, mlibrary-specific CSS now compiles into application.css < all additional custom and updated CSS should be imported with application.scss file.

Modified SCSS pipeline in layouts/application.html.erb, initializers/assets.rb, `package.json'

@rshiggin rshiggin requested a review from ssciolla June 17, 2026 20:50
@rshiggin

Copy link
Copy Markdown
Member Author

CI failures

  • Lint issues in helpers/dul_arclight_helper.rb, helpers/contact_link_helper.rb, helpers/catalog_helper.rb
  • Update brakeman gem 8.0.4 > 8.0.5

@ssciolla ssciolla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rshiggin rshiggin merged commit 31ee8b9 into ARC-135-repositories-view Jun 18, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants