Skip to content

FIX: Set calibration plot axes to screen resolution if available #13558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flying-spagetti wants to merge 6 commits into
base: main
Choose a base branch
from
+6 −0
Open

FIX: Set calibration plot axes to screen resolution if available #13558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8642bd
FIX: Set calibration plot axes to screen resolution if available
flying-spagetti Dec 22, 2025
011ec39
DOC: Adds to contributors and document bugfix for axis limits in cali…
flying-spagetti Dec 23, 2025
dc1c44f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 23, 2025
e712262
DOC: Fix the method reference and sync
flying-spagetti Dec 23, 2025
b63ae72
Merge branch 'main' into fix-calibration-issues
larsoner Dec 24, 2025
5f5e754
Merge branch 'main' into fix-calibration-issues
flying-spagetti Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/dev/13558.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix axis limits in :meth:`mne.preprocessing.eyetracking.calibration.Calibration.plot` to use screen resolution if available, by :newcontrib:`Gnaneswar Lopinti`.
Copy link
Contributor

@scott-huberty scott-huberty Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fix axis limits in :meth:`mne.preprocessing.eyetracking.calibration.Calibration.plot` to use screen resolution if available, by :newcontrib:`Gnaneswar Lopinti`.
Fix axis limits in :meth:`mne.preprocessing.eyetracking.Calibration.plot` to use screen resolution if available, by :newcontrib:`Gnaneswar Lopinti`.

xref the failing test in the build_docs CI

Per the hint in the Warning admonition in the contributing guide, I think that the API entry point we need to reference is mne.preprocessing.eyetracking.Calibration, as this is the entry point we document in python_reference.rst, e.g. here

1 change: 1 addition & 0 deletions doc/changes/names.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
.. _Gennadiy Belonosov: https://github.com/Genuster
.. _Geoff Brookshire: https://github.com/gbrookshire
.. _George O'Neill: https://georgeoneill.github.io
.. _Gnaneswar Lopinti: https://github.com/flying-spagetti
.. _Gonzalo Reina: https://orcid.org/0000-0003-4219-2306
.. _Guillaume Dumas: https://mila.quebec/en/person/guillaume-dumas
.. _Guillaume Favelier: https://github.com/GuillaumeFavelier
Expand Down
4 changes: 4 additions & 0 deletions mne/preprocessing/eyetracking/calibration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ def plot(self, show_offsets=True, axes=None, show=True):

# Invert y-axis because the origin is in the top left corner
ax.invert_yaxis()
if self["screen_resolution"] is not None:
w, h = self["screen_resolution"]
ax.set_xlim(0, w)
ax.set_ylim(h, 0)
ax.scatter(px, py, color="gray")
ax.scatter(gaze_x, gaze_y, color="red", alpha=0.5)

Expand Down
Loading