fixes from the fifth adversarial review (command-set contracts) - #16
Merged
Conversation
…re default, v0.1.1, honest skill contracts Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An adversarial review of the new command set found eight issues: plugin installs expose namespaced command names the README did not document; the release moved without a version bump; five skills could not locate the engine from a fresh standalone install; the baseline still cloned the task repository and never printed its promised unverified-evidence trailer; the documented no-argument score invocation exited with usage; two skill descriptions promised "offline / clones nothing" while requiring ~1.2 GB of clones; trigger descriptions overlapped between paid and free operations; and the README still said "two skills" and omitted the baseline's authentication requirement.
What changed
src/lib/run.ts+src/screen.ts: a variant with no tools and no subagents (the baseline) now runs without cloning or validating the task repository — the guard is attached only for repo-using variants — and the verdict trailer prints "evidence not machine-verified — this variant has no verifier" when no verifier ran.src/score.ts: no run ids defaults tobaseline v3-verify(covered by a new test; 29 total).package.json, both plugin manifests and the marketplace entry;validate:manifestsnow enforces version consistency across all four and checks the engine pins matchv<version>; the two screening skills pin--branch v0.1.1.fairtask-evalshare one engine-location step: current dir →$CLAUDE_PLUGIN_ROOT→$FAIRTASK_HOME→~/.fairtask→ clone the pinned release (announced).fairtask-reportandfairtask-evaldisclose the ~1.2 GB workspace clones in their descriptions and announce before cloning;fairtask-baselinetriggers only when a specific task is supplied and points published-number comparisons at report/score.