Open
Conversation
mobbjon
reviewed
Jan 17, 2022
Collaborator
mobbjon
left a comment
mobbjon
left a comment
There was a problem hiding this comment.
Thanks, looks good, a few comments inside and in general we also add test files to the rules with examples of the vulnerable code and examples of how to do the same thing in a non-vulnerable way. Can you please add them?
| - https://docs.microsoft.com/en-us/security/sdl/cryptographic-recommendations | ||
| patterns: | ||
| - pattern: | | ||
| $K = $C.getInstance("$RE"); |
Collaborator
There was a problem hiding this comment.
can we change this to something like:
- pattern-inside: |
$K = $C.getInstance("$RE");
... - pattern: $K.initialize($BITS);
- fix: $K.initialize(2048);
and this way we can have an auto-fix as well?
| @@ -0,0 +1,25 @@ | |||
| - id: java-use-of-des-encryption-algorithm | |||
| message: | | |||
| DES is a weak algorithm that has known attacks and can be broken. Consider using a secure algorithm such as AES. | |||
Collaborator
There was a problem hiding this comment.
Is it possible to add an auto-fix for this rule? Not sure how the fix should look like so it is hard to say..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added 2 semgrep rules for detecting weak encryption, specifically DES encryption algorithm and RSA algorithm with a short key (less than 2048 bits). Each rule is in a separate file.