Skip to content

fix: launch android apps on emulators with hw.keyboard = no#223

Merged
gmegidish merged 1 commit intomainfrom
fix/android-launch-pct-syskeys
May 5, 2026
Merged

fix: launch android apps on emulators with hw.keyboard = no#223
gmegidish merged 1 commit intomainfrom
fix/android-launch-pct-syskeys

Conversation

@gmegidish
Copy link
Copy Markdown
Member

pass --pct-syskeys 0 to monkey to avoid failure when the emulator has no physical keyboard configured (exit status 251).

pass --pct-syskeys 0 to monkey to avoid failure when the emulator has
no physical keyboard configured (exit status 251).
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c3970a3a-3a74-4b67-9e8d-a1a26b9175ec

📥 Commits

Reviewing files that changed from the base of the PR and between 6cb7b6a and fbeda70.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • devices/android.go

Walkthrough

This pull request modifies the Android app launch functionality to include a --pct-syskeys 0 argument when invoking the monkey command. The change updates the LaunchApp function in devices/android.go to pass this additional parameter, which sets the syskeys injection percentage to zero. This addresses emulator app-launch scenarios where hw.keyboard = no. The CHANGELOG.md is updated to document this fix.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing Android app launches on emulators without physical keyboards by addressing the hw.keyboard=no configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining the technical rationale for passing --pct-syskeys 0 to monkey to prevent exit status 251 failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/android-launch-pct-syskeys

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant