Open
Conversation
Contributor
|
Hmm.So annoying with the non-optionality of arguments in Go, feels like this isn't something that should have to be expressed in 99% of cases. Is the idea that |
Contributor
Author
|
Yes, it would be the following:
|
thomasjpfan
reviewed
Jan 27, 2026
Contributor
thomasjpfan
left a comment
There was a problem hiding this comment.
Besides the merge conflicts, I'm okay with this for a breaking 0.7 update.
|
|
||
| // Build eagerly builds an Image on Modal. | ||
| func (image *Image) Build(ctx context.Context, app *App) (*Image, error) { | ||
| func (image *Image) Build(ctx context.Context, app *App, params *ImageBuildParams) (*Image, error) { |
Contributor
There was a problem hiding this comment.
Being able to force build everything feels like a DevX gotcha, that I'm not sure how to resolve.
If a developer force builds a registry image, then sandbox in production using that image with DockerfileCommands will run into higher latency because that image will be rebuilt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds force-build support (via MODAL_FORCE_BUILD and modal.toml force_build) and new optional forceBuild params across image APIs in JS/Go; deprecates JS secret arg; breaking: Go image methods now take Params structs.
MODAL_FORCE_BUILDenv andforce_buildin~/.modal.toml(modal-go/config.go,modal-js/src/config.ts).Images.FromRegistry(tag, *ImageFromRegistryParams)(addsForceBuildand optionalSecret).Images.FromAwsEcr(tag, secret, *ImageFromAwsEcrParams)andImages.FromGcpArtifactRegistry(tag, secret, *ImageFromGcpArtifactRegistryParams)(addForceBuild).Image.Build(ctx, app, *ImageBuildParams)(addsForceBuild).Sandbox.Create, examples, tests).forceBuildtoimages.fromRegistry,images.fromAwsEcr,images.fromGcpArtifactRegistry, andImage.build.secrettoImageFromRegistryParams; deprecate separatesecretarg infromRegistry(); updateApp.imageFromRegistry()/static helpers.index.ts.Written by Cursor Bugbot for commit 65e541c. This will update automatically on new commits. Configure here.