Expose forceBuild on fromRegistry()#264
Open
donutdaniel wants to merge 1 commit intomodal-labs:mainfrom
Open
Conversation
Author
|
motivation was encountering stale images during development, and saw that the python sdk had a force build function (as well as the docker commands nested in the code!). These changes are backwards compatible, but feel free to commandeer or let me know if you'd like to approach it in a different way. recently I've been pushing a lot of changes and have let my agents loose with docker - and i find that though tagging the more stable and accepted approach, it is also the slower one, so i just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forceBuildoption tofromRegistry()in both JS and Go SDKsdockerfileCommands()layersfromRegistry(tag, secret)still works alongsidefromRegistry(tag, { secret, forceBuild })Test plan
fromRegistry("alpine", { forceBuild: true })triggers a fresh buildfromRegistry("alpine", secret)still works (backwards compat)🤖 Generated with Claude Code