feat: add JSON-based settings file for authorization-server tests (supersedes #228)#360
Open
pcarleton wants to merge 5 commits into
Open
feat: add JSON-based settings file for authorization-server tests (supersedes #228)#360pcarleton wants to merge 5 commits into
pcarleton wants to merge 5 commits into
Conversation
commit: |
…ypo'd files The settings file must be a complete, valid AuthorizationServerOptions on its own; CLI flags are optional overrides on top. .strict() rejects unknown keys so a typo'd field surfaces as an error instead of being silently ignored. ZodError from file parsing is reported with the file path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #228 by @Michito-Okai. Original commit cherry-picked with authorship preserved (
ba4cd2a), then rebased onto currentmain(post-#227) and tightened up per review.What this adds
A
--file <path>option for theauthorizationsubcommand that loads settings from a JSON file. CLI flags take precedence over file values.Changes vs #228
AuthorizationServerFileOptionsSchemaand the bespokemergeAuthorizationServerOptionshelper. The file isJSON.parsed, generically spread-merged with CLI options (CLI wins;undefinedflags don't clobber file values), then validated once by the existingAuthorizationServerOptionsSchema. Unknown keys are stripped by Zod. New options added to the schema flow through to--fileautomatically.--urlnor--fileis given — explicit guard before Zod parse, instead of a crypticurl: Invalid input.examples/authorization-server-settings.example.jsonwith anhttps://issuer (RFC 8414).mainand conflict-resolved against feat: scenario option for authorization server test #227's--scenario/--verboseadditions.Files
src/index.ts—--fileoption, load + spread-merge + url guardexamples/authorization-server-settings.example.json— samplesrc/authorization-file-options.test.ts— merge/validation testsCloses #228.
Addresses #225.