-
Notifications
You must be signed in to change notification settings - Fork 669
Add application_type to Dynamic Client Registration per MCP spec SEP-837
#1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
044e279
20e4dec
57a9888
71a2c97
fcf950e
bff2ac4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace ModelContextProtocol.Authentication; | ||
|
|
@@ -48,4 +49,18 @@ internal sealed class DynamicClientRegistrationRequest | |
| /// </summary> | ||
| [JsonPropertyName("scope")] | ||
| public string? Scope { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the application type for the client, as defined in OpenID Connect Dynamic Client Registration 1.0. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// Valid values are "native" and "web". Per the MCP specification, MCP clients MUST specify an appropriate | ||
| /// application type during Dynamic Client Registration. This field is automatically populated by the SDK | ||
| /// based on the redirect URI if not explicitly set via <see cref="DynamicClientRegistrationOptions.ApplicationType"/>. | ||
| /// Native applications (desktop, mobile, CLI, localhost web apps) should use "native". | ||
| /// Web applications (remote browser-based) should use "web". | ||
| /// </remarks> | ||
| [JsonPropertyName("application_type")] | ||
| [Experimental(Experimentals.DcrApplicationType_DiagnosticId, UrlFormat = Experimentals.DcrApplicationType_Url)] | ||
| public string? ApplicationType { get; init; } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @copilot this should also be annotated as experimental
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in bff2ac4. |
||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.