-
Notifications
You must be signed in to change notification settings - Fork 9
C# SDK: align mode value and priorityHint with the SEP #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PederHP
wants to merge
4
commits into
main
Choose a base branch
from
fix/issue-15-mode-priorityhint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0cc036b
Rename InterceptorMode.Active to Enforce per SEP
PederHP 32043ce
Support per-phase priorityHint object form per SEP
PederHP 82b552f
Guard chain execution against non-wire phase values
PederHP 58edf2c
Revert mode value to "active" to match revised SEP-1763
PederHP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
csharp/sdk/src/ModelContextProtocol.Interceptors/Protocol/PriorityHint.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| using System.Text.Json; | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace ModelContextProtocol.Interceptors.Protocol; | ||
|
|
||
| /// <summary> | ||
| /// Priority hint for ordering mutation interceptors. Lower values execute first; ties are broken | ||
| /// alphabetically by interceptor name. Per the SEP, a hint is either a single number applying to | ||
| /// both phases or an object with separate <c>request</c>/<c>response</c> values; an unset phase | ||
| /// value resolves to 0. | ||
| /// </summary> | ||
| [JsonConverter(typeof(Converter))] | ||
| public sealed class PriorityHint | ||
| { | ||
| /// <summary>Creates a scalar hint applying the same priority to both phases.</summary> | ||
| public PriorityHint(int value) | ||
| { | ||
| Request = value; | ||
| Response = value; | ||
| IsScalar = true; | ||
| } | ||
|
|
||
| /// <summary>Creates a per-phase hint. An unset phase resolves to 0.</summary> | ||
| public PriorityHint(int? request, int? response) | ||
| { | ||
| Request = request; | ||
| Response = response; | ||
| } | ||
|
|
||
| /// <summary>Gets the request-phase priority, or <see langword="null"/> if unset (resolves to 0).</summary> | ||
| public int? Request { get; } | ||
|
|
||
| /// <summary>Gets the response-phase priority, or <see langword="null"/> if unset (resolves to 0).</summary> | ||
| public int? Response { get; } | ||
|
|
||
| /// <summary> | ||
| /// Whether this hint was created or parsed in scalar (single number) form. Controls whether it | ||
| /// serializes back as a bare number or an object, preserving round-trip fidelity. | ||
| /// </summary> | ||
| internal bool IsScalar { get; } | ||
|
|
||
| /// <summary>Resolves the effective priority for the given phase per the SEP algorithm.</summary> | ||
| public int GetEffective(InterceptorPhase phase) => | ||
| phase == InterceptorPhase.Response ? Response ?? 0 : Request ?? 0; | ||
|
|
||
| /// <summary>Converts a plain number to a scalar hint applying to both phases.</summary> | ||
| public static implicit operator PriorityHint(int value) => new(value); | ||
|
|
||
| internal sealed class Converter : JsonConverter<PriorityHint> | ||
| { | ||
| public override PriorityHint? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) | ||
| { | ||
| switch (reader.TokenType) | ||
| { | ||
| case JsonTokenType.Number: | ||
| return new PriorityHint(reader.GetInt32()); | ||
|
|
||
| case JsonTokenType.StartObject: | ||
| int? request = null, response = null; | ||
| while (reader.Read() && reader.TokenType != JsonTokenType.EndObject) | ||
| { | ||
| var propertyName = reader.GetString(); | ||
| reader.Read(); | ||
| switch (propertyName) | ||
| { | ||
| case "request": request = reader.GetInt32(); break; | ||
| case "response": response = reader.GetInt32(); break; | ||
| default: reader.Skip(); break; | ||
| } | ||
| } | ||
| return new PriorityHint(request, response); | ||
|
|
||
| default: | ||
| throw new JsonException($"Unexpected token '{reader.TokenType}' for priorityHint; expected a number or an object."); | ||
| } | ||
| } | ||
|
|
||
| public override void Write(Utf8JsonWriter writer, PriorityHint value, JsonSerializerOptions options) | ||
| { | ||
| if (value.IsScalar) | ||
| { | ||
| writer.WriteNumberValue(value.Request!.Value); | ||
| return; | ||
| } | ||
|
|
||
| writer.WriteStartObject(); | ||
| if (value.Request is int request) writer.WriteNumber("request", request); | ||
| if (value.Response is int response) writer.WriteNumber("response", response); | ||
| writer.WriteEndObject(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.