You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rebased this branch on current main and force-pushed 3fdd4b3.
The rebase conflict was in tests/shared/test_streamable_http.py after upstream converted the protocol-version checks to the in-process async client fixture. I kept the upstream async protocol-version coverage and re-applied this PR's SEP-2243 mcp-method / mcp-name header regression test on top.
Closing this — main now sends the SEP-2243 routing headers directly: _per_message_headers() adds Mcp-Method (and Mcp-Name for tools/call) on modern protocol versions, and _prepare_headers() already pins MCP-Protocol-Version on every request. That covers what this PR added, and the in-tree version goes further (e.g. encoding the tool name and leaving room for the prompts/get / resources/read name params). No reason to keep a competing implementation open. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-methodheaders to streamable HTTP POST requestsmcp-namefor tool calls, prompt gets, and resource read/subscribe/unsubscribe requestsTo verify
uv run pytest tests/shared/test_streamable_http.py -quv run ruff check src/mcp/client/streamable_http.py tests/shared/test_streamable_http.pyuv run ruff format --check src/mcp/client/streamable_http.py tests/shared/test_streamable_http.pygit diff --check