fix: prevent CRLF translation in stdio_server on Windows#2743
Closed
Epochex wants to merge 2 commits into
Closed
Conversation
|
I ran an independent Windows-focused repro packet from Agent Windows Lab and it supports the direction of this PR. Environment/evidence:
Command used: python .\scripts\run_agent_windows_lab.py --out .\artifacts\issue-packet --case mcp --issue-target modelcontextprotocol-python-sdk
python .\scripts\verify_redacted_report.py .\artifacts\issue-packet\agent-windows-lab-report.jsonPublic harness commit: yyzquwu/agent-windows-lab@ab5e714 This gives independent Windows evidence for treating stdio framing as byte-level transport behavior and preventing text-mode newline translation from leaking into JSON-RPC framing. |
Member
|
You've opened a duplicated pull request, please search opened PRs before creating new ones. Duplicated from #2552. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2433.
On Windows, TextIOWrapper defaults to newline=None and translates \n -> \r\n on output. stdio_server wraps sys.stdout.buffer with TextIOWrapper, so every JSON-RPC message was emitted with CRLF line endings.
This sets newline= on the stdio stdin/stdout wrappers to disable platform newline translation and keep LF-delimited NDJSON.
Tests: