fix: gate ClientSessionGroup lists on capabilities#2954
Closed
fengjikui wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientSessionGroupconsult the negotiated server capabilities before listing prompts, resources, or toolsMCPErrorwarning fallback when a server advertises a capability but the list call still failsFixes #2689.
Validation
uv run pytest tests/client/test_session_group.py::test_client_session_group_skips_unadvertised_capabilities -qenv -u ALL_PROXY -u all_proxy -u HTTP_PROXY -u http_proxy -u HTTPS_PROXY -u https_proxy uv run pytest tests/client/test_session_group.py -quv run ruff check src/mcp/client/session_group.py tests/client/test_session_group.pyuv run ruff format --check src/mcp/client/session_group.py tests/client/test_session_group.pyuv run pyright src/mcp/client/session_group.py tests/client/test_session_group.pyNote: the full
test_session_group.pyrun needs proxy env vars unset locally because this shell hasALL_PROXY=socks5://127.0.0.1:7890and the test constructs anhttpx.AsyncClient; with the proxy removed, the file passes.