fix: check_capability now validates elicitation sub-capabilities (form/url)#2966
Closed
Robin1987China wants to merge 1 commit into
Closed
Conversation
…m/url) Schema has ElicitationCapability.form and .url sub-fields but check_capability only validated the top-level elicitation key. A client that supports URL elicitation but not form elicitation would incorrectly return True when the caller checks for form. Fix matches the existing sampling sub-capability pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2965
Connection.check_capability()only checked the top-levelelicitationkey — if the client declared ANY elicitation support, all sub-capability checks passed. A client supporting only URL elicitation would incorrectly returnTruewhen checked for form elicitation.Fix
Added
form/urlsub-capability checks matching the existingsamplingsub-capability pattern (.context/.tools).Tests
5 new parametrized test cases covering:
AI assistance: Bug discovered, analyzed, and fix implemented with AI assistance (opencode).