Read UTF-8 test fixtures with explicit encoding - #3245
Open
ShuQingDollarVoyager wants to merge 1 commit into
Open
Read UTF-8 test fixtures with explicit encoding#3245ShuQingDollarVoyager wants to merge 1 commit into
ShuQingDollarVoyager wants to merge 1 commit into
Conversation
Path.read_text() without an encoding argument uses the locale preferred encoding, which on Windows is the ANSI code page (e.g. GBK on Chinese-locale systems). manifest.toml and the story sources are UTF-8, so tests/examples failed to collect or run there. Fixes modelcontextprotocol#3244 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3244.
Two
Path.read_text()calls intests/examplesomit theencodingargument, so they decode with the locale preferred encoding - on Windows that is the ANSI code page. On non-Western-locale Windows (e.g. Chinese locale, cp936/GBK) this raisesUnicodeDecodeError:tests/examples/conftest.py:41fails at collection (8 collection errors blocking the whole directory) andtests/examples/test_story_shape.py:30fails ~70 parametrized tests. CI'swindows-latestuses cp1252, which happens to decode the same bytes without raising, so this only reproduces on non-Western locales.Both files being read (
manifest.toml, story sources) are UTF-8 - TOML is UTF-8 by specification - so this passesencoding=utf-8explicitly at both call sites.Test plan
uv run pytest tests -n autoon Chinese-locale Windows 10 (cp936): 70 failed, 8 collection errors.Disclosure
This fix was prepared with AI assistance (Claude Code); I have reviewed and verified the change myself.
🤖 Generated with Claude Code