fix: improve error logging and remove token secret from logs#685
Draft
fix: improve error logging and remove token secret from logs#685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Quick follow-up to #680 to make a few small fixes:
debug!("refresh token: {:?}", refresh_token)was logging the refresh token secret, which should never appear inlogs
try_refresh_or_reauthcatchesTokenRefreshFailed, the original reason was discarded from both the error and the log, making refresh failures harder to diagnosetoken_received_atisNonewas correct but non-obvious without a commentHow Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context