-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(client,core): application_type client metadata with native/web inference (SEP-837) #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattzcarey
wants to merge
4
commits into
main
Choose a base branch
from
feat/sep-837-application-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ad24ad5
feat(client,core): application_type client metadata with native/web i…
mattzcarey 67a5f82
test(conformance): remove SEP-837 application_type entries from expec…
mattzcarey dfb5ebd
fix(client): tighten application type inference
mattzcarey 6e9527f
chore(codemod): update generated package versions
mattzcarey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| '@modelcontextprotocol/client': minor | ||
| '@modelcontextprotocol/core': patch | ||
| --- | ||
|
|
||
| Support `application_type` client metadata with native/web inference for dynamic client registration (SEP-837) | ||
|
|
||
| Per the MCP authorization specification, clients MUST specify an appropriate `application_type` when registering dynamically: OIDC-based authorization servers default the field to `'web'`, which conflicts with native/loopback redirect URIs and can cause registration to fail. | ||
|
|
||
| - `OAuthClientMetadataSchema` (and therefore `OAuthClientInformationFullSchema`) now includes an optional `application_type` field, so user-supplied values are no longer stripped from registration requests or responses. | ||
| - `registerClient()` infers `application_type` when it is absent from the provided metadata: `'native'` if every redirect URI is an HTTP loopback URI (`localhost`, `127.0.0.1`, `[::1]`) or uses a custom non-http(s) scheme, otherwise `'web'`. An explicitly provided value is never overridden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| // AUTO-GENERATED — do not edit. Run `pnpm run generate:versions` to regenerate. | ||
| export const V2_PACKAGE_VERSIONS: Record<string, string> = { | ||
| '@modelcontextprotocol/client': '^2.0.0-alpha.2', | ||
| '@modelcontextprotocol/server': '^2.0.0-alpha.2', | ||
| '@modelcontextprotocol/node': '^2.0.0-alpha.2', | ||
| '@modelcontextprotocol/express': '^2.0.0-alpha.2', | ||
| '@modelcontextprotocol/server-legacy': '^2.0.0-alpha.2', | ||
| '@modelcontextprotocol/core': '^2.0.0-alpha.0' | ||
| '@modelcontextprotocol/client': '^2.0.0-alpha.3', | ||
| '@modelcontextprotocol/server': '^2.0.0-alpha.3', | ||
| '@modelcontextprotocol/node': '^2.0.0-alpha.3', | ||
| '@modelcontextprotocol/express': '^2.0.0-alpha.3', | ||
| '@modelcontextprotocol/server-legacy': '^2.0.0-alpha.3', | ||
| '@modelcontextprotocol/core': '^2.0.0-alpha.1' | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.