docs(core): @deprecated elicitationId / ElicitationCompleteNotification* (spec #2891)#2372
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
…deprecated (spec #2891) The neutral schemas keep these (2025-era URL-mode flow still uses them); the 2026-07-28 wire codec already excludes the notification. Per the project rule: neutral schemas never drop, only @deprecated; per-revision strictness lives in the wire/rev*/ forks.
felixweinberger
force-pushed
the
fweinberger/deprecate-elicitation-complete
branch
from
9588740 to
19fc972
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — JSDoc-only deprecation tags following the established SEP-2577 / 2025-era deprecation pattern; the earlier changeset and server-method-tag suggestions remain optional follow-ups.
Extended reasoning...
Overview
This PR only adds @deprecated JSDoc annotations to ElicitationCompleteNotificationParamsSchema, ElicitationCompleteNotificationSchema, the elicitationId field on ElicitRequestURLParamsSchema (in packages/core/src/types/schemas.ts), and the corresponding ElicitationCompleteNotificationParams / ElicitationCompleteNotification type aliases (in packages/core/src/types/types.ts). No Zod validation logic, runtime behavior, or exports change — the schemas and types are byte-for-byte identical apart from comments.
Security risks
None. The change is documentation-only; it cannot affect parsing, validation, transport behavior, or auth.
Level of scrutiny
Low. This is the textbook 'simple, mechanical' change: it mirrors the dozens of existing @deprecated annotations already in the same files (SEP-2577 logging/sampling/roots stacks, 2025-11-25 task vocabulary), and the deprecation rationale matches the spec change (#2891 removed the elicitation-complete notification in 2026-07-28; the 2026 wire codec already excludes it, per the same-day commit 19fc972 in the repo history). The wording is consistent with the surrounding comment style.
Other factors
The bug hunting system found no bugs. My two prior inline comments (missing changeset for the .d.ts-visible deprecation, and optionally tagging Server.createElicitationCompletionNotifier() in packages/server) are nits explicitly framed as dismissible and don't affect the correctness of this diff — the changeset omission also has direct counter-precedent in the repo (PR #2326 merged a docs-only @deprecated sweep without one). Nothing here requires a design decision or human judgment beyond those optional follow-ups.
1 participant
Adds
@deprecatedJSDoc to the neutral-schema entries removed from the spec by #2891. No runtime change; the 2026-07-28 wire codec already excludes the notification.Types of changes
Checklist