fix: correct loop condition in chunk function

[Yikic]

The previous loop condition while subseg_st + dur < ed + step caused the last audio segment to be skipped in some cases.
Changed the condition to while subseg_st < ed to ensure the entire duration is covered.

[gemini-code-assist]

Summary of Changes

Hello @Yikic, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the audio segmentation logic where the previous loop condition could lead to the omission of the final audio segment. By adjusting the loop's termination condition, the change ensures that all intended audio segments are properly processed, improving the robustness and accuracy of the chunking mechanism.

Highlights

• Loop Condition Fix: The while loop condition in the chunk function has been corrected from subseg_st + dur < ed + step to subseg_st < ed. This change ensures that the last audio segment is not inadvertently skipped during processing, guaranteeing full coverage of the audio duration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request corrects the loop condition in the chunk function to prevent skipping audio segments. While the fix is an improvement in correctness and clarity, it can lead to the creation of very short chunks at the end of a segment. I've provided a suggestion to implement a more robust chunking strategy that ensures all chunks have a substantial length, which should improve the reliability of speaker embedding extraction.

[Yikic]

The old version could drop a standalone 0.75s chunk or shorter. If short chunks are an issue, we can implement an additional filter_short_chunks function to handle them.