docs: build note for funasr-common (A1 follow-up)#2996
Conversation
…iniaudio audio loader)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for llama.cpp runtime by adding a step to copy the shared audio loader (funasr-common) to the examples/ directory. The feedback suggests moving the inline bash comment to its own line above the command to prevent copy-paste issues in different terminal environments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ## Build (shared) | ||
| ```bash | ||
| git clone https://github.com/ggml-org/llama.cpp && cd llama.cpp | ||
| cp -r /path/to/runtime/llama.cpp/funasr-common examples/ # shared audio loader (miniaudio); each example CMake adds ../funasr-common |
There was a problem hiding this comment.
Placing comments inline within a bash code block can sometimes cause issues when users copy and paste the entire block directly into their terminal (especially across different shells or terminal emulators). Moving the comment to its own line above the command improves readability and copy-paste safety.
| cp -r /path/to/runtime/llama.cpp/funasr-common examples/ # shared audio loader (miniaudio); each example CMake adds ../funasr-common | |
| # Copy the shared audio loader (miniaudio); each example's CMake adds ../funasr-common | |
| cp -r /path/to/runtime/llama.cpp/funasr-common examples/ |
1 participant
Adds the missing build step: copy
funasr-common/(shared miniaudio audio loader) intoexamples/alongside the example dir; each example's CMake includes../funasr-common. Closes the A1 follow-up requested in review.