Skip to content

docs: fix contact image paths in runtime SDK tutorials - #3764

Merged
LauraGPT merged 1 commit into
modelscope:mainfrom
pratikgx:docs-fix-sdk-tutorial-images
Oct 8, 2026
Merged

LauraGPT merged 1 commit into
modelscope:mainfrom
pratikgx:docs-fix-sdk-tutorial-images

Conversation

@pratikgx

@pratikgx pratikgx commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Summary

The contact table at the bottom of the six runtime SDK tutorials links its two images with ../../../docs/images/.... From runtime/docs/ that goes one level above the repository root, so both images are broken on GitHub. The DingTalk image is also stored as dingding.png, not dingding.jpg.

This changes the paths to ../../docs/images/dingding.png and ../../docs/images/wechat.png in:

  • runtime/docs/SDK_tutorial.md
  • runtime/docs/SDK_tutorial_en.md
  • runtime/docs/SDK_tutorial_en_zh.md
  • runtime/docs/SDK_tutorial_online.md
  • runtime/docs/SDK_tutorial_online_zh.md
  • runtime/docs/SDK_tutorial_zh.md

Type of change

  • Bug fix
  • Documentation
  • Example or demo
  • Runtime or deployment
  • Benchmark or evaluation
  • Model/training change

Validation

Docs-only change, 6 lines. Confirmed docs/images/dingding.png and docs/images/wechat.png exist at main, and resolved every relative link in the six changed files against the repository tree; all of them now point to existing files. No code paths are touched, so compileall and runtime tests are not applicable.

  • python -m compileall funasr examples tests
  • Docs or links checked
  • Runtime/deployment command tested

User impact

Readers of the offline and online SDK tutorials (English and Chinese) see the DingTalk and WeChat group QR codes instead of broken images.

Notes for reviewers

Path-only change, no content edits.

@LauraGPT LauraGPT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 1786f15. All six SDK Markdown files are byte-for-byte unchanged except the two intended contact-image path replacements on one line per file; each of the 12 changed references resolves to an existing repository PNG. Current-main integration only adds the already-verified #3765 NumPy workflow to the original review base, leaving these documents and images unchanged. Product-site run 37568472557 is now successful after its existing workflow was read and approved once: document-link, build/validation, and browser gates passed. No blocking findings. This does not verify QR payloads or runtime inference, and no deployment was performed.

@LauraGPT
LauraGPT merged commit 75494e7 into modelscope:main Oct 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants