Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the version to 1.1.0.dev0 and introduces support for variable keyword arguments in rotary positional embedding functions across gpt_model.py and patcher.py. A review comment suggests avoiding the in-place modification of the kwargs dictionary in patcher.py to prevent unintended side effects for callers.
| logger.warning_once('Using non-batched RoPE, which may affect performance.') | ||
| kwargs = {'cp_group': cp_group} if mcore_013 else {} | ||
| if mcore_013: | ||
| kwargs['cp_group'] = cp_group |
There was a problem hiding this comment.
Modifying the kwargs dictionary in-place can lead to unexpected side effects for the caller. It's safer to create a new dictionary for the call, which avoids mutating the object passed by the caller.
Suggested change
| kwargs['cp_group'] = cp_group | |
| kwargs = {**kwargs, 'cp_group': cp_group} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.