feat(extensions): cap pane size responsively - #1091
Draft
benvinegar wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Extension panes can use a responsive preferred fraction, but their maximum size is fixed in terminal cells. A pane that should stay subordinate to the review can therefore consume too much space on smaller terminals or after a resize.
Approach
ExtensionPaneSize.maxFractionin extension API v26max,maxFraction, and review minimum-space constraintsThis is deliberately an extension pane sizing primitive, not a new built-in pane policy.
Verification
bun test packages/hunk/src/extensions/runExtension.test.ts packages/hunk/src/ui/lib/extensionPanes.test.ts packages/hunk/src/ui/hooks/useExtensionPaneController.test.tsx(87 passed)bun test test/pty/extensions-integration.test.ts(21 passed)bun run typecheckbun run lintbun run format:checkbun run check:docsbun run deps:checkbun run build:npm && bun run check:packbun run changeset:statusbun run test(2,198 passed, 3 skipped, 1 unrelated failure inpackages/hunk/src/lib/shikiWasm.test.ts; reproduced unchanged onorigin/main)Evidence
No visual capture yet; this is opened as a draft while deciding whether to keep the API.