Skip to content

Unify sidebar naming in the app shell#150

Merged
benvinegar merged 1 commit intomainfrom
pi/unify-sidebar-terminology
Mar 31, 2026
Merged

Unify sidebar naming in the app shell#150
benvinegar merged 1 commit intomainfrom
pi/unify-sidebar-terminology

Conversation

@benvinegar
Copy link
Copy Markdown
Member

Summary

  • rename the sidebar component and app-shell state from FilesPane-style names to sidebar-oriented names
  • rename the responsive layout flag to showSidebar and align the resize helpers and width bookkeeping with that terminology
  • update the affected UI and interaction tests to use the same sidebar wording

Testing

  • bun run typecheck
  • bun test test/app-interactions.test.tsx test/ui-components.test.tsx test/ui-lib.test.ts

This PR description was generated by Pi using OpenAI o3

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 31, 2026

Greptile Summary

This is a pure rename/refactoring PR that unifies sidebar terminology across the app shell — replacing FilesPane-style identifiers with sidebar-oriented names throughout App.tsx, responsive.ts, the component file itself, and the associated tests. No logic changes are made.

  • FilesPane.tsx renamed to SidebarPane.tsx and its exported function renamed to SidebarPane
  • ResponsiveLayout.showFilesPane renamed to showSidebar (all four return sites in responsive.ts updated consistently)
  • All derived state, refs, callbacks, and constants in App.tsx updated (filesPaneWidthsidebarWidth, filesScrollRefsidebarScrollRef, showFilesPanerenderSidebar, beginFilesPaneResize / updateFilesPaneResize / endFilesPaneResizebeginSidebarResize / updateSidebarResize / endSidebarResize, etc.)
  • Tests in ui-components.test.tsx and app-interactions.test.tsx updated to reflect the new names
  • No stale references to the old names remain anywhere in the codebase

Confidence Score: 5/5

Safe to merge — purely a rename refactor with no logic changes and full codebase coverage.

The diff is a systematic rename with no logic modifications. All call sites are updated, the interface change in responsive.ts is applied at every return point, no stale references remain, and tests have been updated to match. No P0 or P1 findings were identified.

No files require special attention.

Important Files Changed

Filename Overview
src/ui/App.tsx Comprehensive rename of all FilesPane-style identifiers to sidebar-oriented names; no logic changes, all references are consistently updated.
src/ui/components/panes/SidebarPane.tsx File renamed from FilesPane.tsx; exported function renamed to SidebarPane; retains a local variable fileEntries (filtering entries of kind "file") that was not renamed as part of the refactor.
src/ui/lib/responsive.ts ResponsiveLayout interface field renamed from showFilesPane to showSidebar; all four return sites updated consistently; no logic changes.
test/app-interactions.test.tsx One test description updated from "files pane" to "sidebar" wording; no test logic changed.
test/ui-components.test.tsx Import path updated to SidebarPane, JSX usage and test description renamed accordingly; no test logic changed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[resolveResponsiveLayout\nresponsive.ts] -->|returns showSidebar| B[App.tsx\nresponsiveLayout]
    B --> C{renderSidebar?}
    C -->|true| D[SidebarPane\nSidebarPane.tsx]
    C -->|true| E[PaneDivider]
    C -->|false| F[DiffPane only]
    D -->|scrollRef| G[sidebarScrollRef\njumpToFile / jumpToAnnotatedHunk]
    D -->|width| H[clampedSidebarWidth\nfrom sidebarWidth state]
    E -->|resize events| I[beginSidebarResize\nupdateSidebarResize\nendSidebarResize]
    I --> H
Loading

Reviews (1): Last reviewed commit: "Unify sidebar naming in the app shell" | Re-trigger Greptile

@benvinegar benvinegar merged commit 7f7a4f0 into main Mar 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant