Repository navigation
Pick what needed tags need too, and put Left behind in the release post - #58
Merged
Merged
Conversation
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #56.
Pick N needed tags now finishes the job. A needed tag can ship more tasks that need tags of their own. Before, the button picked one round, and a second button appeared. Now
neededPicksrepeats on a copy of the picks until no line needs a tag, so one click is enough and the count on the button includes the follow-on tags. In the demo, picking web 1.9.0 alone now offers "Pick 2 needed tags": api 2.5.0, which SHOP-38 needs, and worker 0.15.0, which api 2.5.0's SHOP-35 needs.To compute that without touching the real picks,
picked,tasksandgapsnow delegate topickedFor(picks),tasksOf(picked)andgapsOf(picked). A line whose tag is already in the copy is skipped, which stops the loop even when a tag is not a candidate.The release post lists what the picks leave behind. When anything is left behind, the post ends with a
Left behind (N)section in the same shape as the list on the page: each task, the services it misses with the reason and links to the merge requests, and the issues it depends on, with their status when they have no changes. Project paths stay full in the post, as in its Services section.Tests: two new smoke tests (cascade pick, post section).
just lint,just test-ci(146, 100%) andjust test-smoke(27) pass; checked in the demo in a browser.