Skip to content

docs(rtd): install docs dependency group in RTD build - #2860

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-rtd-dependency-groups
Sep 30, 2026
Merged

wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-rtd-dependency-groups

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

#2809 moved the docs requirements from the doc extra to a docs dependency group, but .readthedocs.yml still installed .[doc]. This broke the RTD build.

modflowpy#2809 moved the docs requirements from the `doc` extra to a `docs`
dependency group, but .readthedocs.yml still installed `.[doc]`. The
extra no longer exists, so RTD installed bare flopy and the build
failed importing yaml in conf.py (and got unpinned sphinx). Override
the install job to install the `docs` group (needs pip >= 25.1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wpbonelli wpbonelli added this to the 3.11.1 milestone Sep 30, 2026
@wpbonelli wpbonelli added dependencies Pull requests that update a dependency file documentation labels Sep 30, 2026
@wpbonelli wpbonelli changed the title fix(rtd): install docs dependency group in RTD build docs(rtd): install docs dependency group in RTD build Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.7%. Comparing base (556c088) to head (63983c4).
⚠️ Report is 237 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2860      +/-   ##
===========================================
+ Coverage     55.5%    73.7%   +18.2%     
===========================================
  Files          644      659      +15     
  Lines       124135   132399    +8264     
===========================================
+ Hits         68947    97698   +28751     
+ Misses       55188    34701   -20487     

see 586 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli
wpbonelli marked this pull request as ready for review September 30, 2026 13:08
@wpbonelli
wpbonelli merged commit 2ba8a65 into modflowpy:develop Sep 30, 2026
23 of 24 checks passed
@wpbonelli
wpbonelli deleted the fix-rtd-dependency-groups branch September 30, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant