Skip to content

fix: memory issues when importing giant mrpack files#6278

Merged
IMB11 merged 3 commits into
mainfrom
cal/dev-1091
Jun 2, 2026
Merged

fix: memory issues when importing giant mrpack files#6278
IMB11 merged 3 commits into
mainfrom
cal/dev-1091

Conversation

@IMB11
Copy link
Copy Markdown
Member

@IMB11 IMB11 commented Jun 1, 2026

  • Currently, when a mrpack is imported from the file system, the entire mrpack file is loaded into memory.
  • This PR changes it so that if the mrpack is on the file system already it will use the pre-existing file rather than loading it in memory

@IMB11 IMB11 requested a review from aecsocket June 1, 2026 14:05
@IMB11 IMB11 added app Relates to Modrinth App backend Involves work from the backend team labels Jun 1, 2026
@modrinth-bot
Copy link
Copy Markdown
Member

modrinth-bot commented Jun 1, 2026

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

  • Fixed importing large .mrpack files in Modrinth App causing OS freezing or crashing.

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@IMB11 IMB11 marked this pull request as draft June 1, 2026 14:08
@modrinth-bot
Copy link
Copy Markdown
Member

modrinth-bot commented Jun 1, 2026

@IMB11 IMB11 marked this pull request as ready for review June 2, 2026 07:55
@IMB11 IMB11 added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit cfe45b3 Jun 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Relates to Modrinth App backend Involves work from the backend team

Development

Successfully merging this pull request may close these issues.

3 participants