Skip to content

refactor: improve loader detection for Fabric derivatives - #7171

Open
SpaceWalkerRS wants to merge 1 commit into
modrinth:mainfrom
SpaceWalkerRS:improve-loader-detection
Open

refactor: improve loader detection for Fabric derivatives#7171
SpaceWalkerRS wants to merge 1 commit into
modrinth:mainfrom
SpaceWalkerRS:improve-loader-detection

Conversation

@SpaceWalkerRS

Copy link
Copy Markdown

Refactored mod upload loader detection for Fabric and its derivatives. The current logic falls back to Fabric even for versions Fabric does not support, is too quick to resolve to Babric, and does not have any logic for Ornithe at all. I updated the logic to the following:

  1. Check the jar manifest for specific attributes:
    • Legacy-Fabric-Intermediary-Version -> Legacy Fabric
    • Calamus-Generation -> Ornithe
  2. If that yields no results, fall back to Minecraft dependency version checks:
    • b1.7.3 (exactly) -> Babric
    • >=1.3 <=1.13.2 (release only) -> Legacy Fabric
    • >=18w43b -> Fabric (taken from installer list)
    • <=18w43a -> Ornithe (supports up to 1.14.4 but prioritize Fabric)

I implemented similar logic for Quilt since Ornithe works with both Fabric and Quilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants