feat(labrinth): user preferences - #7177
Open
Sychic wants to merge 26 commits into
Open
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
aecsocket
reviewed
Aug 17, 2026
Comment on lines
+400
to
+404
| if requester.id != target.id.into() && !requester.role.is_mod() { | ||
| return Err(ApiError::Auth(eyre!( | ||
| "you do not have permission to access this user's preferences" | ||
| ))); | ||
| } |
Contributor
There was a problem hiding this comment.
would make this a little clearer since it involves an auth precondition
Suggested change
| if requester.id != target.id.into() && !requester.role.is_mod() { | |
| return Err(ApiError::Auth(eyre!( | |
| "you do not have permission to access this user's preferences" | |
| ))); | |
| } | |
| let can_access = requester.id == target.id.into() || requester.role.is_mod(); | |
| if !can_access { | |
| return Err(ApiError::Auth(eyre!( | |
| "you do not have permission to access this user's preferences" | |
| ))); | |
| } |
aecsocket
approved these changes
Aug 17, 2026
Comment on lines
+450
to
+454
| if requester.id != target.id.into() && !requester.role.is_mod() { | ||
| return Err(ApiError::Auth(eyre!( | ||
| "you do not have permission to access this user's preferences" | ||
| ))); | ||
| } |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still need to validate language, couldn't think of a good way to do that yet