refactor(daedalus_client): replace serde-xml-rs with quick-xml - #7185
Open
exefer wants to merge 1 commit into
Open
refactor(daedalus_client): replace serde-xml-rs with quick-xml#7185exefer wants to merge 1 commit into
exefer wants to merge 1 commit into
Conversation
quick-xml is already the de facto XML (de)serializer used elsewhere in the workspace (labrinth, app-lib), so consolidate on it here too. Its serde feature deserializes the existing maven-metadata.xml structs without any changes. Drops one redundant dependency from the workspace.
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde-xml-rswas only used indaedalus_clientfor parsing Forge/NeoForge maven-metadata.xml.quick-xmlhas become the standard XML (de)serializer for Rust and is already used elsewhere in the workspace, so this switchesdaedalus_clientover and drops the now-unusedserde-xml-rsdependency. No functional change, verifiedquick-xml's serde deserialization against the existingMetadata/Versioning/Versionsstructs.