Open
Conversation
Отправка писем вынесена в отдельный метод `miniShop2::shootEmail`, где либо подключается планировщик, либо письмо отправляется сразу.
TolkIT-team
reviewed
Jul 8, 2025
TolkIT-team
left a comment
TolkIT-team
left a comment
There was a problem hiding this comment.
Некоторые моменты бросились в глаза.
| * Creating Sheduler's task for sending email | ||
| * @return false|object|null | ||
| */ | ||
| private function createEmailTask() |
There was a problem hiding this comment.
Не очень понял, почему тут удален метод? Как будет исполняется его функционал?
Contributor
Author
There was a problem hiding this comment.
Может стоить весь код правок посмотреть, прежде чем задавать такие вопросы?
| ); | ||
| if ($scheduler) { | ||
| $sTask = $scheduler->getTask('minishop2', 'ms2_send_email'); | ||
| if (empty($sTask)) { |
There was a problem hiding this comment.
Три вложенных друг в друга if выглядят не очень хорошо.
| } | ||
|
|
||
| $sTask = null; | ||
| if ($force === false && $this->modx->getOption('ms2_use_scheduler', null, false)) { |
There was a problem hiding this comment.
тут было бы эффективнее написать if (!$force
Contributor
Author
There was a problem hiding this comment.
Эффективнее?) Про типы данных не слышал, видимо?
Contributor
Author
Прям бросились?) Сорян, не могу по-другому реагировать на подобного рода "замечания"))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Отправка писем вынесена в отдельный метод
miniShop2::shootEmail, где либо подключается планировщик, либо письмо отправляется сразу.