feat(updater): add Sparkle Stage 1 - minimal UpdateService, menu, and guards (opt-in)#99
Open
3manu31 wants to merge 1 commit into
Open
feat(updater): add Sparkle Stage 1 - minimal UpdateService, menu, and guards (opt-in)#993manu31 wants to merge 1 commit into
3manu31 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(updater): add Sparkle Stage 1 - minimal UpdateService (opt-in)
What does this PR do?
UpdateServicethat initializes Sparkle's updater controller (without starting it automatically) and exposescheckForUpdates().Check for Updatescommand in the app menu to trigger the updater.SUFeedURLis present the button opens the GitHub Releases page.This is a conservative Stage 1 change intended only to add the UI hook and updater wiring so maintainers can review without needing CI secrets, appcast signing, or release-process changes.
Type of change
Files changed
project.yml— add Sparkle SPM package and target product dependencyPureMac/Services/UpdateService.swift— new minimal updater servicePureMac/PureMacApp.swift— addUpdatescommand menu andCheck for UpdatesbuttonPureMac/ViewModels/AppState.swift— small concurrency fix (MainActor wrap forLoggercall)PureMac.xcodeproj/project.pbxproj— Xcode project updated to include Sparkle/package entriesWhy this change
Related issues
Testing done
xcodegen generate→open PureMac.xcodeproj→ Build succeeded.Check for Updatesopens Releases whenSUFeedURLis not set; whenSUFeedURLis present Sparkle's updater is started and checks for updates.How to test locally
xcodegenis installed:brew install xcodegenxcodegen generateopen PureMac.xcodeprojSUFeedURLin the app's Info.plist the app opens the GitHub Releases page (safe fallback).Notes for reviewers
AI-assistance disclosure
Drafted using Claude Code. Built the project locally to confirm my version compiles. I understand what the code does.