test: give each terminal taxonomy case its own timeout budget - #1124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package validation job on main failed because one terminal-taxonomy test performed six sequential durable writes under a single five-second Vitest timeout. It exceeded that budget on the CI runner while the other 654 Modal tests passed.
Parameterize the six categories so each has its own fixture and normal timeout. Retain every category assertion and additionally compare both persisted terminal files with the returned contract. Production behavior and timeout settings are unchanged.
Validation: the focused worker-result tests and the complete Modal suite pass on Node.js 24.20.0, matching CI. Prettier, ESLint, and
git diff --checkpass.Failure evidence: https://github.com/monad-developers/ultrafuzz/actions/runs/34628691377/job/103360889632
Greptile Summary
This PR parameterizes the terminal-taxonomy test so each durable-write category receives an independent timeout budget.
Confidence Score: 5/5
The PR appears safe to merge because the parameterization is valid and preserves the relevant terminal persistence and generation coverage.
Each terminal category now receives a separate test timeout and fixture, while synchronous contract reads occur only after both durable writes complete; no actionable regression was identified.
Important Files Changed
Reviews (1): Last reviewed commit: "test: isolate durable terminal taxonomy ..." | Re-trigger Greptile
Context used: