Skip to content

test: give each terminal taxonomy case its own timeout budget - #1124

Merged
aviggiano merged 1 commit into
mainfrom
fix/modal-terminal-contract-test-timeout
Sep 11, 2026
Merged

aviggiano merged 1 commit into
mainfrom
fix/modal-terminal-contract-test-timeout

Conversation

@aviggiano

@aviggiano aviggiano commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

The package validation job on main failed because one terminal-taxonomy test performed six sequential durable writes under a single five-second Vitest timeout. It exceeded that budget on the CI runner while the other 654 Modal tests passed.

Parameterize the six categories so each has its own fixture and normal timeout. Retain every category assertion and additionally compare both persisted terminal files with the returned contract. Production behavior and timeout settings are unchanged.

Validation: the focused worker-result tests and the complete Modal suite pass on Node.js 24.20.0, matching CI. Prettier, ESLint, and git diff --check pass.

Failure evidence: https://github.com/monad-developers/ultrafuzz/actions/runs/34628691377/job/103360889632

Greptile Summary

This PR parameterizes the terminal-taxonomy test so each durable-write category receives an independent timeout budget.

  • Retains coverage for all six terminal categories.
  • Gives each case an isolated temporary root and writer.
  • Verifies both persisted terminal files equal the returned contract.

Confidence Score: 5/5

The PR appears safe to merge because the parameterization is valid and preserves the relevant terminal persistence and generation coverage.

Each terminal category now receives a separate test timeout and fixture, while synchronous contract reads occur only after both durable writes complete; no actionable regression was identified.

Important Files Changed

Filename Overview
packages/modal/test/worker-result.test.ts Replaces one sequential taxonomy loop with isolated parameterized cases and adds persisted status/result contract assertions.

Reviews (1): Last reviewed commit: "test: isolate durable terminal taxonomy ..." | Re-trigger Greptile

Context used:

@aviggiano
aviggiano merged commit 386727c into main Sep 11, 2026
13 checks passed
@aviggiano
aviggiano deleted the fix/modal-terminal-contract-test-timeout branch September 11, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant