feat(mongodb-runner): usability improvements for drivers DRIVERS-3335 #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
changed the title
addaleax
reviewed
Dec 9, 2025
| await cluster.updateDefaultConnectionOptions({ | ||
| serverApi: String(options.requireApiVersion) as '1', | ||
| }); | ||
| } |
Collaborator
There was a problem hiding this comment.
I'd suggest putting this in a separate method, like we did for addAuthIfNeeded()
| if (buildInfoError) { | ||
| debug('failed to get buildInfo', buildInfoError); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
If a keyfile is being used, wouldn't we want to use it for authentication?
Author
There was a problem hiding this comment.
No, when a keyFile is present you can't do anything on the server until a user has been added to the primary.
| return true; | ||
| } | ||
| // If the server does not support auth, just get the build info without | ||
| // setting the metadata. |
Collaborator
There was a problem hiding this comment.
Which scenario is this intended to cover? buildInfo is behind auth on newer server versions
Author
There was a problem hiding this comment.
It covers arbiters after authentication has been added to the replica set (their behavior is a bit weird), I'll update the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
keyFile: read/write cannot occur until user is added, and can never be done on an arbiterrequireApiVersion, which must be applied after the cluster has started and update the default connection options.argsto be passed as part of the config file.Tested with:
We didn't need to add extra support for unix sockets, instead we pass in the unix socket prefix.
I couldn't think of an elegant way to let
mongodb-runnermanage thekeyFile, perhaps a new top level argumentkeyFileContent?Open Questions
Checklist