CSHARP-6026: Implement retries for pushing and polling packages#1982
Open
sanych-sun wants to merge 10 commits intomongodb:mainfrom
Open
CSHARP-6026: Implement retries for pushing and polling packages#1982sanych-sun wants to merge 10 commits intomongodb:mainfrom
sanych-sun wants to merge 10 commits intomongodb:mainfrom
Conversation
sanych-sun
added
the
chore
Contributor
There was a problem hiding this comment.
Pull request overview
Implements retry logic in the Evergreen packaging pipeline to make NuGet package pushes and subsequent availability polling more resilient to transient failures.
Changes:
- Added a generic
execute_with_retryhelper with backoff. - Reworked package availability polling to retry based on query results rather than fixed sleep loops.
- Wrapped
dotnet nuget pushin retry logic and added logging around push attempts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BorisDog
requested changes
May 4, 2026
| until "$@"; do | ||
| attempt=$((attempt + 1)) | ||
|
|
||
| if [ $attempt -gt $max_attempts ]; then |
Contributor
There was a problem hiding this comment.
minor (Claude): looks like there are max_attempts + 1 attempts. Should this be -ge ?
| echo "sleeping for 15 seconds..." | ||
| sleep 15 | ||
| execute_with_retry() { | ||
| max_attempts=$1 |
Contributor
There was a problem hiding this comment.
nit: Claude suggests local variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.