CSHARP-6013: Change stream events are not emitted for timeseries as of 9.0#1986
Open
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Open
CSHARP-6013: Change stream events are not emitted for timeseries as of 9.0#1986sanych-sun wants to merge 1 commit intomongodb:mainfrom
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Conversation
sanych-sun
added
the
chore
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the unified change streams spec tests for nsType by removing the time series create-case, likely to align the test suite with observed server behavior changes referenced in CSHARP-6013.
Changes:
- Removed the unified test case asserting
nsType: timeserieson time series collection creation. - Kept the remaining coverage for
nsType: collectionandnsType: viewcreate events.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| specifications/change-streams/tests/unified/change-streams-nsType.yml | Removes the time series nsType create test case from the YAML unified spec test. |
| specifications/change-streams/tests/unified/change-streams-nsType.json | Mirrors the YAML change by removing the same time series nsType create test case from the JSON unified spec test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
38
to
41
|
|
||
| - description: "nsType is present when creating timeseries" | ||
| operations: | ||
| - name: dropCollection | ||
| object: *database0 | ||
| arguments: | ||
| collection: &collection0 foo | ||
| - name: createChangeStream | ||
| object: *database0 | ||
| arguments: | ||
| pipeline: [] | ||
| showExpandedEvents: true | ||
| saveResultAsEntity: &changeStream0 changeStream0 | ||
| - name: createCollection | ||
| object: *database0 | ||
| arguments: | ||
| collection: *collection0 | ||
| timeseries: | ||
| timeField: "time" | ||
| metaField: "meta" | ||
| granularity: "minutes" | ||
| - name: iterateUntilDocumentOrError | ||
| object: *changeStream0 | ||
| expectResult: | ||
| operationType: create | ||
| nsType: timeseries | ||
|
|
||
| - description: "nsType is present when creating views" | ||
| operations: | ||
| - name: dropCollection |
| } | ||
| ] | ||
| }, | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.