PHPLIB-1725 Add Session::getSnapshotTime in spec tests#1799
PHPLIB-1725 Add Session::getSnapshotTime in spec tests#1799GromNaN wants to merge 1 commit intomongodb:v2.xfrom
Session::getSnapshotTime in spec tests#1799Conversation
GromNaN
changed the title
Session::getSnapshotTime in spec tests [skip ci]Session::getSnapshotTime in spec tests
| return $session->endSession(); | ||
|
|
||
| case 'getSnapshotTime': | ||
| throw new \RuntimeException('TODO: Implement getSnapshotTime'); |
There was a problem hiding this comment.
Do you mean to add test skips to this PR? Or is it really waiting on PHPLIB-1725 to implemented? I think we're going to need a PHPC ticket between that and CDRIVER-6098 to track the MongoDB\Driver\Session API changes.
I found this property documented in ClientSession Changes in the Snapshot Sessions spec. The change dates back to mongodb/specifications@03795d2 and DRIVERS-2782, although the JIRA title doesn't mention this field.
There was a problem hiding this comment.
I've followed up as DRIVERS-2782 is still in review, meaning that the downstream tickets are still blocked. That said, I've cloned PHPLIB-1725 to PHPC-2658 as we have to expose this as a new method in the MongoDB\Driver\Session class first.
3 participants
Fix PHPLIB-1725
Implement https://github.com/mongodb/specifications/blob/master/source/sessions/tests/README.md#specific-operations-and-behaviour-for-unified-tests
Need the value of
snapshotTimeto be exposed byMongoDB\Driver\Session.