PYTHON-5862 Cleanup lockless uv usage - #2966
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Test failures will be resolved by PYTHON-5974. |
There was a problem hiding this comment.
Pull request overview
This PR cleans up CI and Evergreen test infrastructure by removing the previously-added UV_NO_LOCK environment variable usage (which is not a real uv setting), and adjusts the AWS ECS test harness to avoid failures stemming from lockfile behavior.
Changes:
- Remove
UV_NO_LOCKexports/usages fromjust, GitHub Actions, and Evergreen scripts. - Simplify
[tool.uv]configuration by droppingdefault-groups(thedevgroup is empty). - Fix AWS ECS test environment setup by installing
git(needed to resolve themockupdbgit dependency) and removing any pre-existinguv.lockinside the container.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removes uv default-groups config while keeping exclude-newer behavior. |
| justfile | Drops UV_NO_LOCK export from just execution environment. |
| .github/workflows/test-python.yml | Removes UV_NO_LOCK from workflow environment. |
| .evergreen/scripts/setup-tests.sh | Removes UV_NO_LOCK export before running uv. |
| .evergreen/scripts/kms_tester.py | Removes UV_NO_LOCK from KMS remote command strings. |
| .evergreen/scripts/configure-env.sh | Removes UV_NO_LOCK from exported Evergreen environment. |
| .evergreen/run-tests.sh | Removes UV_NO_LOCK export before running tests. |
| .evergreen/run-mongodb-aws-ecs-test.sh | Installs git and removes uv.lock to address ECS test failures. |
|
So in general we're still creating lock files, but they're git ignored? If so we may want to reconsider because our local dev with almost never be the same as CI. |
There isn't currently a way to prevent invocations of |
|
What I mean is, we might be better off following astral's advice and checking in the lock file, and then having a job that periodically updates the lock file. This would mean going back to using "pip" in the dependabot config to avoid the spurious update PRs. |
PYTHON-5862
Changes in this PR
Removes the no-op
UV_NO_LOCKenvironment variable usage (it doesn't exist anywhere in uv's docs, pure hallucination) in our CI alongside several other confusing and non-functional changes introduced by #2902. Also fixes the persistent failure of test-auth-aws-ecs due to the lockfile removal.Test Plan
Test infra changes.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is there test coverage?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer