Skip to content

Promote dev to main: session-finish credential scope fix #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbigniewsobiecki merged 5 commits into from
May 9, 2026
Merged

Promote dev to main: session-finish credential scope fix #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06e273e
refactor(triggers): extract agent work item linking (#1268)
aaight May 8, 2026
717d00f
refactor(triggers): extract agent execution lifecycle (#1271)
aaight May 8, 2026
43c6b6c
test(triggers): pin trigger contract regressions (#1272)
aaight May 8, 2026
0ba0524
feat(triggers): add canonical events and result builders (#1273)
aaight May 8, 2026
6d80fd0
fix(session-finish): scope GitHub client so PR-lookup fallback works …
zbigniewsobiecki May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 48 additions & 58 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions src/cli/session/finish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Command, Flags } from '@oclif/core';
import { Flags } from '@oclif/core';
import { readCompletionEvidence } from '../../backends/completion.js';
import { validateFinish, writePushedChangesSidecar } from '../../gadgets/session/core/finish.js';
import { finishDef } from '../../gadgets/session/definitions.js';
Expand All @@ -8,6 +8,7 @@ import {
PUSHED_CHANGES_SIDECAR_ENV_VAR,
REVIEW_SIDECAR_ENV_VAR,
} from '../../gadgets/sessionState.js';
import { CredentialScopedCommand } from '../base.js';

function readFinishHooksFromEnv(): SessionHooks {
const raw = process.env.CASCADE_FINISH_HOOKS;
Expand All @@ -20,7 +21,7 @@ function readFinishHooksFromEnv(): SessionHooks {
}
}

export default class Finish extends Command {
export default class Finish extends CredentialScopedCommand {
static override description = finishDef.description;

static override flags = {
Expand All @@ -39,7 +40,7 @@ export default class Finish extends Command {
}),
};

async run(): Promise<void> {
async execute(): Promise<void> {
const { flags } = await this.parse(Finish);
const hooks = readFinishHooksFromEnv();
const evidence = readCompletionEvidence({
Expand Down
2 changes: 2 additions & 0 deletions src/triggers/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ To reduce duplication across the three worker-side handlers, shared utilities ar
| `trigger-resolution.ts` | `resolveTriggerResult()` — pre-resolved or dispatch | Sentry (GitHub and PM use inline logic) |
| `credential-scope.ts` | `withPMScope()` — `withPMCredentials` + `withPMProvider` | GitHub, Sentry |
| `pm-ack.ts` | `postPMAckComment()` — posts ack to Trello/JIRA | GitHub worker handler |
| `events.ts` | `TRIGGER_EVENTS` — typed catalog of canonical trigger event names | Trigger handlers and tests |
| `result-builders.ts` | Builders for dispatch, skip, no-agent, and deferred re-check `TriggerResult` shapes | Trigger handlers and tests |
| `agent-execution.ts` | `runAgentExecutionPipeline()` — full agent lifecycle | All handlers (via `webhook-execution.ts`) |
| `webhook-execution.ts` | `runAgentWithCredentials()` — LLM keys + credentials + pipeline | GitHub, PM |

Expand Down
Loading
Loading