chore: release - merge dev into main#1419
Merged
Merged
Conversation
Co-authored-by: Cascade Bot <bot@cascade.dev>
…ting to Trello A project configured with only an SCM (GitHub) integration and no PM provider was silently treated as Trello: the DB→config mapper defaulted pm.type to 'trello' when no PM integration row existed (and the schema + registry re-applied that default). Every SCM trigger (review, respond-to-review, check-suite-*, respond-to-pr-comment) then failed dispatch trying to load a Trello credential that does not exist: Integration credential 'pm/trello/api_key' not found for project '<id>' Make the PM provider optional end-to-end: - schema: `pm` is optional with no Trello default (src/config/schema.ts). - config mapper: derive pm.type only from a present trello/jira/linear integration; leave `pm` undefined for SCM-only projects (src/db/repositories/configMapper.ts). - registry: createProvider returns a new NO_PM_PROVIDER sentinel (and resolveLifecycleConfig an empty config) when pm is undefined — never a phantom Trello provider (src/pm/registry.ts, src/pm/no-pm-provider.ts). withPMProvider requires a non-null PMProvider, so a no-op sentinel keeps every call site type-safe; its PM operations throw loudly if ever reached. - propagate the optional type through router config, prompt context, friction types, and the worker env (CASCADE_PM_TYPE is omitted for SCM-only projects). withPMCredentials already short-circuits on an undefined pmType, and the capacity gate only runs for PM status-changed dispatch, so SCM triggers are unaffected. Genuine Trello/JIRA/Linear projects keep pm.type exactly as before. Tests: NO_PM_PROVIDER + registry no-op, configMapper/schema leave pm undefined, github adapter dispatches an SCM-only project with withPMCredentials(undefined), plus updates to the previously trello-defaulting tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address review: the SCM-only sentinel is truthy, so buildPromptContext still used it for workItemUrl and terminology — and NO_PM_PROVIDER.getWorkItemUrl() throws synchronously, boot-failing an SCM-only run that carries a workItemId (e.g. a stale pr_work_items row or a manual/retry path) before the agent runs. Normalize the sentinel to null once and use that value for workItemUrl, terminology, and pmType. Adds a regression test that buildPromptContext with NO_PM_PROVIDER in scope + a workItemId does not throw. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ovider fix(pm): support SCM-only projects (no PM provider) instead of defaulting to Trello
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release: merge dev into main. Includes the optional-PM-provider fix (SCM-only projects with no PM provider) plus prior dev commits. (Created manually — the release workflow's gh pr create choked on a double-quote in a commit headline.)