fix(signal-tracker): firefox and chromium loop over different stack traces (@Leonabcd123)#7754
Open
Leonabcd123 wants to merge 1 commit intomonkeytypegame:masterfrom
Open
fix(signal-tracker): firefox and chromium loop over different stack traces (@Leonabcd123)#7754Leonabcd123 wants to merge 1 commit intomonkeytypegame:masterfrom
Leonabcd123 wants to merge 1 commit intomonkeytypegame:masterfrom
Conversation
Leonabcd123
changed the title
Leonabcd123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First signal's first frame in
framesarray inmonkeytype/frontend/src/ts/dev/signal-tracker.ts
Line 35 in 82bf095
Chromium:
at getCallerInfo (http://localhost:3000/ts/dev/signal-tracker.ts?t=1774961577350:5:16)Firefox:
DEV.hooks.afterRegisterGraph@http://localhost:3000/ts/dev/signal-tracker.ts?t=1774961577350:84:34They both should be referring to
getCallerInfo, but only chromium does, because firefox slices off that frame in the code linked above, while chromium slices off the string "Error".Doesn't really matter because the
getCallerInfoframe will be skipped anyways, but this should still be done to make behavior more consistent across different browsers.