Skip to content

fix(quotes): use edited quote length instead of original (@HmonWutt) #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HmonWutt wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −5
Open

fix(quotes): use edited quote length instead of original (@HmonWutt) #8233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c515924
fix(quotes): use edited quote length instead of original (@HmonWutt)
HmonWutt Jul 14, 2026
6c1c011
fix(quotes): use quote.group instead of hardcoded length thresholds i…
HmonWutt Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/src/dal/new-quotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,11 @@ export async function approve(
);
}
const language = targetQuote.language;
const approvedText = editQuote ?? targetQuote.text;
const quote: ApproveQuote = {
text: editQuote ?? targetQuote.text,
text: approvedText,
source: editSource ?? targetQuote.source,
length: targetQuote.text.length,
length: approvedText.length,
approvedBy: name,
Comment thread
HmonWutt marked this conversation as resolved.
id: -1,
};
Expand Down
7 changes: 4 additions & 3 deletions frontend/src/ts/components/modals/QuoteSearchModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,10 @@ function exactSearch(quotes: Quote[], captured: RegExp[]): [Quote[], string[]] {
}

function getLengthDesc(quote: Quote): string {
if (quote.length < 101) return "short";
if (quote.length < 301) return "medium";
if (quote.length < 601) return "long";
if (quote.group === 0) return "short";
if (quote.group === 1) return "medium";
if (quote.group === 2) return "long";
if (quote.group === 3) return "thicc";
return "thicc";
}

Expand Down
Loading