test(backend): improve addResult test coverage (@NINJA-1029)#8239
Open
NINJA-1029 wants to merge 1 commit into
Open
test(backend): improve addResult test coverage (@NINJA-1029)#8239NINJA-1029 wants to merge 1 commit into
NINJA-1029 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more tests for the
addResultcontroller inresult.spec.ts.I noticed that some validation and error paths were not covered by the existing tests, so I added tests for those cases. I also updated the existing success test to check that
xpBreakdown.dailyis updated correctly.Changes
Added tests for validation and guard clause cases, including:
TEST_TOO_SHORTRESULT_HASH_INVALIDRESULT_SPACING_INVALIDMISSING_KEY_DATADUPLICATE_RESULTAdded helper configuration for
enableObjectHashCheckandenableLastHashesCheckwhere needed by the tests.Updated the existing
"should add result"test to verify thexpBreakdown.dailyfield.Verification
pnpm vitest run backend/__tests__/api/controllers/result.spec.ts— all 43 tests passed.pnpm oxlint --type-aware --type-check— no warnings or errors.