impr(weakspot): score within-word bigrams instead of characters (@JMLegere) - #8403
Open
JMLegere wants to merge 1 commit into
Open
impr(weakspot): score within-word bigrams instead of characters (@JMLegere)#8403JMLegere wants to merge 1 commit into
JMLegere wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Weakspot currently attributes typing latency to individual characters. This means a slow 'th' transition makes h appear weak even when other transitions into h, such as sh, are fast.
This PR changes Weakspot to track bigrams. Candidate words are scored using the average of their observed bigram scores.
I did not touch the existing 5,000 ms error penalty, moving average, 20-candidate word selection, or session-local storage. There are no new settings, analytics, or persistence.
This PR also:
Related to discussion #8104. This proposes a smaller change to the existing Weakspot Funbox than the persistent Learning Mode described there.
Note: Implementation and tests were done with AI assistance.
Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.tsCloses #